fix(CLI): sam resources hidden in changeset diffs #29223
Conversation
github-actions
bot
added
bug
comcalvi
added
pr-linter/exempt-integ-test
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
comcalvi
changed the title
github-actions
bot
added
bug
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-maintainer-review
| Changes: [ | ||
| { | ||
| Type: 'Resource', | ||
| ResourceChange: { | ||
| Action: 'Modify', | ||
| LogicalResourceId: 'ServerlessFunction', | ||
| ResourceType: 'AWS::Lambda::Function', // The SAM transform is applied before the changeset is created, so the changeset has a Lambda resource here! | ||
| Replacement: 'False', | ||
| Details: [{ | ||
| Evaluation: 'Direct', | ||
| Target: { | ||
| Attribute: 'Properties', | ||
| Name: 'Code', | ||
| RequiresRecreation: 'Never', | ||
| }, | ||
| }], | ||
| }, | ||
| }, | ||
| ], | ||
| }); | ||
| expect(differences.resources.differenceCount).toBe(1); |
There was a problem hiding this comment.
Curious what would the changes look like before this change?
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Issue # (if applicable)
Closes #29185
Reason for this change
CFN applies the SAM transform before the changeset is created. This means that SAM resources become their underlying CFN types in the template that the changeset operates on. This means that the changeset is operating on resources that we don't see in our template.
Description of changes
Before, if we saw properties in our diff that were not in the changeset (like
codeUriforServerless::Function, which doesn't appear in the changeset, because it becomesCodeforLambda::Function), we'd filter them out of the diff. We now skip this process for SAM resources.Description of how you validated changes
unit test
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license