Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eks): trainium instance types #29155

Merged
merged 4 commits into from Mar 15, 2024
Merged

feat(eks): trainium instance types #29155

merged 4 commits into from Mar 15, 2024

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Feb 18, 2024

@freschri – It's a little hard to find docs on this but I think this is what you're after?

Closes #29131.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team February 18, 2024 19:34
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels Feb 18, 2024
@msambol
Copy link
Contributor Author

msambol commented Feb 18, 2024

Exemption request: I don't think integration is required here?

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Feb 18, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 18, 2024
@freschri
Copy link
Contributor

@freschri – It's a little hard to find docs on this but I think this is what you're after?

Closes #29131.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

it looks like it thanks. I would just ensure all INFERENTIA used have now a TRINIUM check too

@msambol
Copy link
Contributor Author

msambol commented Feb 27, 2024

@tmokmss Have time for this one? pretty straight-forward..

Copy link
Contributor

@tmokmss tmokmss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. since I'm not really familiar with EKS nor Trainium, I commented only about general code quality.

packages/aws-cdk-lib/aws-eks/lib/cluster.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Mar 2, 2024
@msambol
Copy link
Contributor Author

msambol commented Mar 2, 2024

LGTM. since I'm not really familiar with EKS nor Trainium, I commented only about general code quality.

Good feedback, thanks @tmokmss 👍🏼

@shikha372
Copy link
Contributor

@msambol PR looks good just some small nits highlighted in above comments, for the integration test could we add simple test like current ones for inferentia instance type:
https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-inference-nodegroup.ts
https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-inference.ts

@msambol
Copy link
Contributor Author

msambol commented Mar 14, 2024

@paulhcsun possible to get this one in too? I'm going to open a slew of PRs this weekend, want to clean up what's out there now 😄

@paulhcsun paulhcsun added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Mar 15, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 15, 2024 17:53

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@paulhcsun
Copy link
Contributor

@msambol looks good to me, I'm just waiting on another PR to merge and then i'll update branch and be good to approve

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3cf2106
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Mar 15, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 507b709 into aws:main Mar 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. effort/medium Medium work item – several days of effort p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-eks): Neuron device plugin is not installed when instance type is Trainium
6 participants