Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-cdk-lib/aws-appsync: Missing documentation on support for environment variables in GraphQL resolvers and functions #29118

Closed
FelixRelli opened this issue Feb 15, 2024 · 4 comments · Fixed by #29064
Labels
@aws-cdk/aws-appsync Related to AWS AppSync documentation This is a problem with documentation. effort/small Small work item – less than a day of effort p2

Comments

@FelixRelli
Copy link

Describe the issue

AWS announced support for environment variables in GraphQL resolvers and functions including cdk: https://aws.amazon.com/about-aws/whats-new/2024/02/aws-appsync-environment-variables-graph-ql-resolvers-functions/

The documentation is missing implementation details for cdk though: https://docs.aws.amazon.com/appsync/latest/devguide/environmental-variables.html

Could it be that it is not yet implemented in cdk as I could not find any property in the latest release for env variables?

The Context in @aws-appsync/utils already has env as a property though.

Links

https://docs.aws.amazon.com/appsync/latest/devguide/environmental-variables.html

@FelixRelli FelixRelli added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Feb 15, 2024
@github-actions github-actions bot added the @aws-cdk/aws-appsync Related to AWS AppSync label Feb 15, 2024
@hoegertn
Copy link
Contributor

see #29064

@FelixRelli
Copy link
Author

@hoegertn thanks for the quick reply. Guess the marketing team was a bit too fast with claiming cdk support :D
Looking forward to seeing it merged!

@tim-finnigan tim-finnigan linked a pull request Feb 15, 2024 that will close this issue
1 task
@tim-finnigan tim-finnigan self-assigned this Feb 15, 2024
@tim-finnigan tim-finnigan added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Feb 15, 2024
@tim-finnigan
Copy link

Thanks for opening this issue, it looks like that announcement could have been better clarified. I went ahead and linked that PR to auto-close this issue when merged.

@tim-finnigan tim-finnigan added p2 effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Feb 15, 2024
@tim-finnigan tim-finnigan removed their assignment Feb 15, 2024
@mergify mergify bot closed this as completed in #29064 Feb 23, 2024
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-appsync Related to AWS AppSync documentation This is a problem with documentation. effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants