feat(applicationautoscaling): timezone for ScheduledAction #29116
+47
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
distinguished-contributor
aws-cdk-automation
previously requested changes
Feb 15, 2024
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
robertd
force-pushed
the
appscaling-scaling-schedule-timezone
branch
from
6787f82
to
ec75169
Compare
robertd
force-pushed
the
appscaling-scaling-schedule-timezone
branch
from
ec75169
to
91d94e5
Compare
This module doesn't have any integ tests. Exemption Request |
aws-cdk-automation
added
the
pr-linter/exemption-requested
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-community-review
|
My biggest regret is getting my schedule -> core PR reverted 😭 |
|
@kaizencc is that PR abandoned due to technical difficulties or it’s on the back burner?
In the meantime… can we merge this in :) ?
…On Thu, Feb 15, 2024 at 8:50 AM Kaizen Conroy ***@***.***> wrote:
My biggest regret is getting my schedule -> core PR reverted 😭
—
Reply to this email directly, view it on GitHub
<#29116 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAHWNZ3J7EGYRM32XVWB53YTYVD5AVCNFSM6AAAAABDJKWFIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBWGM3TSNRSGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
kaizencc
added
the
pr-linter/exempt-integ-test
kaizencc
approved these changes
Feb 15, 2024
kaizencc
changed the title
kaizencc
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
removed
the
pr/needs-community-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
GavinZZ
pushed a commit
that referenced
this pull request
Feb 22, 2024
Closes #22645 Closes #27754 Spiritual successor of #27052 Somewhat related to #21181 but that might be another PR down the road. @pahud ✋ Please review. I'm not particularly fond of how `aws-autoscaling` module ([here](https://github.com/aws/aws-cdk/blob/256cca4017a80f8643c5f5a5999a2ce0383eebf0/packages/aws-cdk-lib/aws-autoscaling/lib/scheduled-action.ts#L21)) is not using `cdk.TimeZone` class, hence why used it in this PR instead. I think we should we change `aws-autoscaling` implementation to do the same? It would be a breaking change... and most likely a brand new PR. LMK what you think. ✌️ Also, I may be slightly OCD but I kinda like better `timezone` vs `timeZone`, but I went with latter one to follow what `aws-autoscaling` did. cc-ing @kaizencc for his input too 🙌 ... possibly related to #27105 ### Reason for this change Timezones have been supported in `AWS::ApplicationAutoScaling::ScalableTarget ScheduledAction` for a while now. https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-applicationautoscaling-scalabletarget-scheduledaction.html#cfn-applicationautoscaling-scalabletarget-scheduledaction-timezone ### Description of changes Just added the support for `timezones` in `scalableTarget.scaleOnSchedule` ### Description of how you validated changes Added unit tests for this feature. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22645
Closes #27754
Spiritual successor of #27052
Somewhat related to #21181 but that might be another PR down the road.
@pahud ✋ Please review. I'm not particularly fond of how
aws-autoscalingmodule (here) is not usingcdk.TimeZoneclass, hence why used it in this PR instead. I think we should we changeaws-autoscalingimplementation to do the same? It would be a breaking change... and most likely a brand new PR. LMK what you think. ✌️Also, I may be slightly OCD but I kinda like better
timezonevstimeZone, but I went with latter one to follow whataws-autoscalingdid.cc-ing @kaizencc for his input too 🙌 ... possibly related to #27105
Reason for this change
Timezones have been supported in
AWS::ApplicationAutoScaling::ScalableTarget ScheduledActionfor a while now.https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-applicationautoscaling-scalabletarget-scheduledaction.html#cfn-applicationautoscaling-scalabletarget-scheduledaction-timezone
Description of changes
Just added the support for
timezonesinscalableTarget.scaleOnScheduleDescription of how you validated changes
Added unit tests for this feature.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license