Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pipes-sources): new EventBridge Pipes sources alpha module #29048

Merged
merged 7 commits into from Feb 9, 2024

Conversation

RaphaelManke
Copy link
Contributor

@RaphaelManke RaphaelManke commented Feb 9, 2024

Issue # (if applicable)

Closes #.

Reason for this change

This PR adds a new alpha module to for EvenBridge pipes sources.

This is the base setup for future work and additional sources.

Description of changes

The initial source is the SQS source.

Description of how you validated changes

  • Unittests
  • Integration test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team February 9, 2024 17:01
@github-actions github-actions bot added p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK labels Feb 9, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@RaphaelManke RaphaelManke force-pushed the raphaelmanke/aws-pipes-sources-alpha branch 2 times, most recently from 3b3b841 to e72cd58 Compare February 9, 2024 18:53
@RaphaelManke RaphaelManke marked this pull request as ready for review February 9, 2024 19:05
@RaphaelManke RaphaelManke force-pushed the raphaelmanke/aws-pipes-sources-alpha branch from 81a5c7f to be095a9 Compare February 9, 2024 19:21
@mrgrain mrgrain changed the title feat(pipes-sources): EventBridge Pipes sources alpha module feat(pipes-sources): add EventBridge Pipes sources alpha module Feb 9, 2024
@mrgrain mrgrain changed the title feat(pipes-sources): add EventBridge Pipes sources alpha module feat(pipes-sources): new EventBridge Pipes sources alpha module Feb 9, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 9, 2024 19:33

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

mergify bot commented Feb 9, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0801c5b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 2e53568 into aws:main Feb 9, 2024
9 checks passed
Copy link
Contributor

mergify bot commented Feb 9, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TheRealAmazonKendra pushed a commit that referenced this pull request Feb 9, 2024
### Issue # (if applicable)
Closes #.

### Reason for this change



This PR adds a new alpha module to for EvenBridge pipes sources. 

This is the base setup for future work and additional sources. 

### Description of changes



The initial source is the SQS source. 

### Description of how you validated changes


- [x] Unittests
- [x] Integration test

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants