fix(appconfig): deprecate deploy method #29021
Conversation
github-actions
bot
added
the
admired-contributor
aws-cdk-automation
added
the
pr/needs-community-review
There was a problem hiding this comment.
Couple of minor things
- wouldn't call this a refactor. we want this to show up in the changelog, so lets call it a fix
- part of the stabilization process if/when we get there, will be to remove deprecated properties. so what this PR means is that we plan on removing this API in the future. just want to confirm.
chenjane-dev
force-pushed
the
env-deploy-method
branch
from
e0bdae5
to
c306f63
Compare
chenjane-dev
changed the title
|
Updated as a fix. Yes we plan on removing this once we stabilize |
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
removed
the
pr/needs-community-review
kaizencc
added
pr-linter/exempt-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
### Reason for this change Want to recommend against creating AppConfig resources across multiple stacks. ### Description of changes ### Description of how you validated changes ### Checklist - [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Reason for this change
Want to recommend against creating AppConfig resources across multiple stacks.
Description of changes
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license