Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apigatewayv2-integrations): stepfunctions integration #28982

Merged
merged 15 commits into from Feb 28, 2024

Conversation

badmintoncryer
Copy link
Contributor

@badmintoncryer badmintoncryer commented Feb 4, 2024

Issue

Closes #28904.

Reason for this change

It is not possible to create an integration between Step Functions and HTTP API.

Description of changes

You can create integration by HttpStepFunctionsIntegration class:

declare const httpApi: apigwv2.HttpApi;
declare const stateMachine: sfn.StateMachine;

const integration = new HttpStepFunctionIntegration('StepFunctionIntegration', {
	stateMachine,
  })

    httpApi.addRoutes({
      path: '/jobs',
      methods: [apigwv2.HttpMethod.POST],
      integration,
    });

Description of how you validated changes

Added unit tests and integ test.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels Feb 4, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team February 4, 2024 21:14
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review February 5, 2024 16:21

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@badmintoncryer badmintoncryer marked this pull request as ready for review February 6, 2024 15:04
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 6, 2024
colifran
colifran previously approved these changes Feb 26, 2024
Copy link
Contributor

@colifran colifran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for your work on this.

Copy link
Contributor

mergify bot commented Feb 26, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 26, 2024
Copy link
Contributor

mergify bot commented Feb 26, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@badmintoncryer
Copy link
Contributor Author

badmintoncryer commented Feb 26, 2024

@colifran thank you for your review!!
But, mergify job seems to be failed. This is occured in other PR (#29086)
Could you solve it??

@badmintoncryer
Copy link
Contributor Author

@mergify update

Copy link
Contributor

mergify bot commented Feb 27, 2024

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/request-cli-integ-test.yml without workflows permission

@badmintoncryer
Copy link
Contributor Author

@kaizencc
I'm sorry for the sudden contact. As mentioned above, the Mergify job has failed for some reason.
The same problem is occurred at #29086
Could you tell me how to solve this?

@colifran
I apologize if you have already been working towards a solution!

@colifran
Copy link
Contributor

@badmintoncryer sorry I missed your original message. I'm taking a look!

@mergify mergify bot dismissed colifran’s stale review February 28, 2024 14:35

Pull request has been modified.

@badmintoncryer
Copy link
Contributor Author

@colifran Thanks a lot!!

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 39f9267
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 28, 2024
Copy link
Contributor

mergify bot commented Feb 28, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 19d75d6 into aws:main Feb 28, 2024
14 checks passed
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 28, 2024
@badmintoncryer badmintoncryer deleted the 28904-stepfunctionsIntegration branch February 28, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. effort/medium Medium work item – several days of effort p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_apigatewayv2: Can't define HTTP API Step Functions integration with JWT authorizer
3 participants