(aws-cdk-lib/aws-ecs-patterns): Add ability to set healthCheck property for ApplicationLoadBalancedFargateService
#28796
Labels
effort/medium
Medium work item – several days of effort
feature-request
A feature should be added or improved.
p2
Comments
Nikola-Milovic
added
feature-request
pahud
added
p2
effort/medium
|
Thank you for the PR. |
mergify bot
pushed a commit
that referenced
this issue
Feb 6, 2024
…edFargateService` (#28797) Closes #28796 Like with other `aws-ecs-pattern` high level constructs, some properties aren't exposed. For `aws_ecs_patterns`.`ApplicationLoadBalancedFargateService` this is `healthCheck` property of the container. There are already similar PRs #18219 for other constructs in the `aws_ecs_patterns` lib *Note*: I didn't add any test cases since `ApplicationLoadBalancedFargateService` does not seem to have them like the others do. I can maybe come back with another PR to add the test cases. I didn't update the docs since it's a minor addition. And there is already an example for the `QueueProcessingFargateService` that uses the `healthCheck`, it might be redundant to add the same code example with different constructor name. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
TheRealAmazonKendra
pushed a commit
that referenced
this issue
Feb 9, 2024
…edFargateService` (#28797) Closes #28796 Like with other `aws-ecs-pattern` high level constructs, some properties aren't exposed. For `aws_ecs_patterns`.`ApplicationLoadBalancedFargateService` this is `healthCheck` property of the container. There are already similar PRs #18219 for other constructs in the `aws_ecs_patterns` lib *Note*: I didn't add any test cases since `ApplicationLoadBalancedFargateService` does not seem to have them like the others do. I can maybe come back with another PR to add the test cases. I didn't update the docs since it's a minor addition. And there is already an example for the `QueueProcessingFargateService` that uses the `healthCheck`, it might be redundant to add the same code example with different constructor name. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the feature
Similar request as #15636
ApplicationLoadBalancedFargateServicecurrently does not offer healthCheck options propertyUse Case
I want to set custom healthcheck property on my container
Proposed Solution
Add the healthcheck property to
ApplicationLoadBalancedFargateServiceand pass it to the containerhttps://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-ecs-patterns/lib/fargate/application-load-balanced-fargate-service.ts#L83
Something like https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-ecs-patterns/lib/fargate/queue-processing-fargate-service.ts#L26 from
QueueProcessingFargateServicePropsOther Information
No response
Acknowledgements
CDK version used
2.94.0 (build 987c329)
Environment details (OS name and version, etc.)
22.04 Ubuntu
The text was updated successfully, but these errors were encountered: