-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(appsync): add dependency to logretention for graphql apis log group #28548
Conversation
packages/@aws-cdk-testing/framework-integ/test/aws-appsync/test/integ.appsync-logmetrics.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @mrlikl!
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This change adds a dependency to log retention if logconfig is set for
GraphqlApi
. This in turn avoids the race condition when subsequent resources refer to the log group property ofGraphqlApi.logGroup
logGroup is now referring to the custom resource's output log ARN and further resources will depend on the custom resource to be created first.
Closes #26564
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license