Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rds): ClientPasswordAuthType property on DatabaseProxy #28540

Merged
merged 5 commits into from
Jan 3, 2024
Merged

feat(rds): ClientPasswordAuthType property on DatabaseProxy #28540

merged 5 commits into from
Jan 3, 2024

Conversation

lpizzinidev
Copy link
Contributor

Adds support for ClientPasswordAuthType on DatabaseProxy construct.

Closes #28415.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Dec 31, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team December 31, 2023 16:38
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 31, 2023
@github-actions github-actions bot mentioned this pull request Jan 1, 2024
Closed
kaizencc
kaizencc previously requested changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor nit @lpizzinidev. Everything else looks good :)

packages/aws-cdk-lib/aws-rds/lib/proxy.ts Outdated
/**
* Specifies the details of authentication used by a proxy to log in as a specific database user.
*
* @default - The default client password authentication type for the database engine is used.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: this @default tag doesn't provide any useful information. is there a link to a doc that shows what the defaults are for different database engines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to find one.
I agree that this is unclear, but I'm not sure how we should state this.
Should we just say that CloudFormation handles the default given the specified engine?

Copy link
Contributor

@kaizencc kaizencc Jan 3, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, lets just say CloudFormation handles the default. Should be clear that its not us making the decisions.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 2, 2024
@kaizencc kaizencc changed the title feat(rds): support ClientPasswordAuthType on DatabaseProxy feat(rds): ClientPasswordAuthType property on DatabaseProxy Jan 2, 2024
@mergify mergify bot dismissed kaizencc’s stale review January 3, 2024 14:54

Pull request has been modified.

kaizencc
kaizencc approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lpizzinidev

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 3, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: cca50ce
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 669e6ff into aws:main Jan 3, 2024
9 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 3, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

paulhcsun pushed a commit to paulhcsun/aws-cdk that referenced this pull request Jan 5, 2024
@lpizzinidev @paulhcsun
feat(rds): ClientPasswordAuthType property on DatabaseProxy (aws#28540)
afb3788 
Adds support for [`ClientPasswordAuthType`](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-rds-dbproxy-authformat.html#cfn-rds-dbproxy-authformat-clientpasswordauthtype) on `DatabaseProxy` construct.

Closes aws#28415.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaizencc kaizencc kaizencc approved these changes

Assignees
No one assigned
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-rds): Support configuring ClientPasswordAuthType on DBProxy
3 participants
@lpizzinidev @aws-cdk-automation @kaizencc