Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ecs): interactive option in ContainerDefinitionOptions #28536

Merged
merged 11 commits into from Jan 2, 2024
Merged

feat(ecs): interactive option in ContainerDefinitionOptions #28536

merged 11 commits into from Jan 2, 2024

Conversation

badmintoncryer
Copy link
Contributor

This pull request adds the interactive argument to ContainerDefinitionOptions. This argument is used when deploying containerized applications that require the allocation of standard input (stdin) or a terminal (tty). This parameter corresponds to OpenStdin in the "Create a container" section of the Docker Remote API and the --interactive option to docker run.

Closes #24326.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the effort/medium Medium work item – several days of effort label Dec 31, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team December 31, 2023 05:58
@github-actions github-actions bot added feature-request A feature should be added or improved. p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK labels Dec 31, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Dec 31, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@badmintoncryer badmintoncryer changed the title Support interactive option in ContainerDefinitionOptions feat(ecs): Support interactive option in ContainerDefinitionOptions Dec 31, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 31, 2023 15:33

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 31, 2023
@github-actions github-actions bot mentioned this pull request Jan 1, 2024
Closed
lpizzinidev
lpizzinidev suggested changes Jan 1, 2024
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍
I left some comments for minor adjustments.

packages/aws-cdk-lib/aws-ecs/lib/container-definition.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-ecs/README.md Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-ecs/README.md Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-ecs/lib/container-definition.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 1, 2024
badmintoncryer and others added 4 commits January 2, 2024 19:19
@badmintoncryer @lpizzinidev
Update packages/aws-cdk-lib/aws-ecs/README.md
1b034f8 
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
@badmintoncryer @lpizzinidev
Update packages/aws-cdk-lib/aws-ecs/README.md
785369f 
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
@badmintoncryer @lpizzinidev
Update packages/aws-cdk-lib/aws-ecs/lib/container-definition.ts
55cb250 
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
@badmintoncryer @lpizzinidev
Update packages/aws-cdk-lib/aws-ecs/lib/container-definition.ts
a2568d7 
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
@badmintoncryer
Copy link
Contributor Author

@lpizzinidev Thank you for your review! I have made the revisions as per your suggestion.

@kaizencc kaizencc changed the title feat(ecs): Support interactive option in ContainerDefinitionOptions feat(ecs): interactive option in ContainerDefinitionOptions Jan 2, 2024
kaizencc
kaizencc previously approved these changes Jan 2, 2024
View reviewed changes
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 2, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed kaizencc’s stale review January 2, 2024 15:43

Pull request has been modified.

@badmintoncryer
Copy link
Contributor Author

@kaizencc I apologize, I didn't notice the approval and accidentally updated the branch.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 12cccc1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 2, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 1f9788f into aws:main Jan 2, 2024
11 checks passed
@badmintoncryer badmintoncryer deleted the 24326-addInteractiveProperties branch January 3, 2024 00:20
paulhcsun pushed a commit to paulhcsun/aws-cdk that referenced this pull request Jan 5, 2024
@badmintoncryer @paulhcsun
feat(ecs): interactive option in ContainerDefinitionOptions (aws#…
9bcc523 
…28536)

This pull request adds the `interactive` argument to `ContainerDefinitionOptions`. This argument is used when deploying containerized applications that require the allocation of standard input (stdin) or a terminal (tty). This parameter corresponds to `OpenStdin` in the "Create a container" section of the Docker Remote API and the `--interactive` option to `docker run`.

Closes aws#24326.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpizzinidev lpizzinidev lpizzinidev requested changes

@kaizencc kaizencc kaizencc approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(cdk_ecs): interactive property missing in container definition
4 participants
@badmintoncryer @aws-cdk-automation @lpizzinidev @kaizencc