Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ecs): enable cluster to grant task protection API permissions to IAM entities #28486

Merged
merged 8 commits into from Dec 27, 2023
Merged

feat(ecs): enable cluster to grant task protection API permissions to IAM entities #28486

merged 8 commits into from Dec 27, 2023

Conversation

badmintoncryer
Copy link
Contributor

Added a grantTaskProtection method to the ECS (Elastic Container Service) Cluster. This method grants ECS tasks the necessary permissions to interact with the task protection API.

Closes #26233

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team December 25, 2023 10:20
@github-actions github-actions bot added valued-contributor [Pilot] contributed between 6-12 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Dec 25, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Dec 25, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@badmintoncryer badmintoncryer marked this pull request as ready for review December 25, 2023 12:57
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 25, 2023 12:57

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 25, 2023
@badmintoncryer badmintoncryer changed the title feat(ecs): Implement grantTaskProtection method for ECS cluster task role permissions feat(ecs): grant task protection API permissions to IAM entities Dec 25, 2023
@badmintoncryer badmintoncryer changed the title feat(ecs): grant task protection API permissions to IAM entities feat(ecs): enable cluster to grant task protection API permissions to IAM entities Dec 25, 2023
go-to-k
go-to-k suggested changes Dec 26, 2023
View reviewed changes
Copy link
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

It looks good. I have only minor comments.

packages/aws-cdk-lib/aws-ecs/lib/cluster.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-ecs/README.md Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 26, 2023
badmintoncryer and others added 3 commits December 27, 2023 13:35
@badmintoncryer @go-to-k
Update packages/aws-cdk-lib/aws-ecs/lib/cluster.ts
dc173ea 
Co-authored-by: k.goto <24818752+go-to-k@users.noreply.github.com>
@badmintoncryer @go-to-k
Update packages/aws-cdk-lib/aws-ecs/README.md
3654e6e 
Co-authored-by: k.goto <24818752+go-to-k@users.noreply.github.com>
@badmintoncryer @go-to-k
Update packages/aws-cdk-lib/aws-ecs/lib/cluster.ts
d0f6594 
Co-authored-by: k.goto <24818752+go-to-k@users.noreply.github.com>
@badmintoncryer
Copy link
Contributor Author

@go-to-k Thank you for the review. I have made the revisions as you suggested.

go-to-k
go-to-k approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 27, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 27, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 27, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 21665f1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 9bc972b into aws:main Dec 27, 2023
12 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 27, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions github-actions bot mentioned this pull request Jan 1, 2024
Closed
paulhcsun pushed a commit to paulhcsun/aws-cdk that referenced this pull request Jan 5, 2024
@badmintoncryer @paulhcsun
feat(ecs): enable cluster to grant task protection API permissions to…
b7800ce 
… IAM entities (aws#28486)

Added a `grantTaskProtection` method to the ECS (Elastic Container Service) Cluster. This method grants ECS tasks the necessary permissions to interact with the task protection API.

Closes aws#26233

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@badmintoncryer badmintoncryer deleted the 26233-addGrantTaskProtection branch January 31, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@go-to-k go-to-k go-to-k approved these changes

@sumupitchayan sumupitchayan sumupitchayan approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-ecs): Give Cluster a grant method for the task protection API
4 participants
@badmintoncryer @aws-cdk-automation @go-to-k @sumupitchayan