Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(elasticloadbalancingv2): FIPS compliant SSL policy to ALB #28479

Merged
merged 4 commits into from
Dec 23, 2023
Merged

feat(elasticloadbalancingv2): FIPS compliant SSL policy to ALB #28479

merged 4 commits into from
Dec 23, 2023

Conversation

badmintoncryer
Copy link
Contributor

This Pull Request introduces a set of new FIPS-compliant SSL policies for the Application Load Balancer (ALB) in AWS Elastic Load Balancing (ELB). These policies enhance the security of ALB by providing options that are compliant with the Federal Information Processing Standards (FIPS).

Closes #28455

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team December 23, 2023 14:03
@github-actions github-actions bot added valued-contributor [Pilot] contributed between 6-12 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Dec 23, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Dec 23, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@badmintoncryer badmintoncryer changed the title (elasticloadbalancingv2): Add FIPS compliant SSL policy to ALB feat(elasticloadbalancingv2): Add FIPS compliant SSL policy to ALB Dec 23, 2023
@badmintoncryer badmintoncryer changed the title feat(elasticloadbalancingv2): Add FIPS compliant SSL policy to ALB chore(elasticloadbalancingv2): Add FIPS compliant SSL policy to ALB Dec 23, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 23, 2023 14:28

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@badmintoncryer badmintoncryer marked this pull request as ready for review December 23, 2023 14:30
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 23, 2023
@kaizencc kaizencc changed the title chore(elasticloadbalancingv2): Add FIPS compliant SSL policy to ALB feat(elasticloadbalancingv2): FIPS compliant SSL policy to ALB Dec 23, 2023
@kaizencc kaizencc added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Dec 23, 2023
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 23, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 23, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 25d59a8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 7bb72e1 into aws:main Dec 23, 2023
9 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 23, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@badmintoncryer badmintoncryer deleted the 28455-addFipsSslPolicy branch December 23, 2023 22:45
@github-actions github-actions bot mentioned this pull request Jan 1, 2024
Closed
paulhcsun pushed a commit to paulhcsun/aws-cdk that referenced this pull request Jan 5, 2024
@badmintoncryer @paulhcsun
feat(elasticloadbalancingv2): FIPS compliant SSL policy to ALB (aws#2…
0512554 
…8479)

This Pull Request introduces a set of new FIPS-compliant SSL policies for the Application Load Balancer (ALB) in AWS Elastic Load Balancing (ELB). These policies enhance the security of ALB by providing options that are compliant with the Federal Information Processing Standards (FIPS).

Closes aws#28455 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaizencc kaizencc kaizencc approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws-elasticloadbalancingv2: SslPolicy enum doesn't include FIPS policies
3 participants
@badmintoncryer @aws-cdk-automation @kaizencc