Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-ses: The naming convention for the dedicated IP pool cannot be confirmed. #28451

Closed
1 of 2 tasks
badmintoncryer opened this issue Dec 21, 2023 · 2 comments · Fixed by #28466
Closed
1 of 2 tasks

aws-ses: The naming convention for the dedicated IP pool cannot be confirmed. #28451

badmintoncryer opened this issue Dec 21, 2023 · 2 comments · Fixed by #28466
Labels
@aws-cdk/aws-ses Related to Amazon Simple Email Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@badmintoncryer
Copy link
Contributor

Describe the feature

The dedicated pool has specific characters that can be used in its name.

I propose a feature for CDK to verify that it adheres to this naming convention.

Use Case

If a name containing forbidden characters is set for the dedicated IP pool, no error occurs at the stage of ‘cdk synth’, but it fails during deployment. Therefore, I believe it would be preferable to trigger an error at the synth stage.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.115.0

Environment details (OS name and version, etc.)

irrelevant
@badmintoncryer badmintoncryer added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 21, 2023
@github-actions github-actions bot added the @aws-cdk/aws-ses Related to Amazon Simple Email Service label Dec 21, 2023
@badmintoncryer badmintoncryer changed the title aws-ses: Confirm the naming convention for the dedicated IP pool. aws-ses: The naming convention for the dedicated IP pool cannot be confirmed. Dec 21, 2023
@khushail
Copy link
Contributor

Hi @badmintoncryer , that request makes sense. Thanks for submitting it and agreeing to work on it. Team would be happy to review your PR.

@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Dec 21, 2023
@badmintoncryer badmintoncryer mentioned this issue Dec 22, 2023
Merged
@mergify mergify bot closed this as completed in #28466 Dec 22, 2023
mergify bot pushed a commit that referenced this issue Dec 22, 2023
@badmintoncryer
feat(ses): synth-time naming validation for dedicatedIpPoolName (#28466)
be6ddb8 
This Pull Request introduces a new validation feature to the DedicatedIpPoolProps. It ensures that the dedicatedIpPoolName adheres to the specified naming conventions, enhancing data integrity and preventing runtime errors due to invalid names.

Closes #28451

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot mentioned this issue Jan 1, 2024
Closed
paulhcsun pushed a commit to paulhcsun/aws-cdk that referenced this issue Jan 5, 2024
@badmintoncryer @paulhcsun
feat(ses): synth-time naming validation for dedicatedIpPoolName (aws#…
e608a19 
…28466)

This Pull Request introduces a new validation feature to the DedicatedIpPoolProps. It ensures that the dedicatedIpPoolName adheres to the specified naming conventions, enhancing data integrity and preventing runtime errors due to invalid names.

Closes aws#28451

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ses Related to Amazon Simple Email Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ses): synth-time naming validation for dedicatedIpPoolName badmintoncryer/aws-cdk
2 participants
@badmintoncryer @khushail