feat(lambda-event-sources): S3EventSource requires Bucket instead of IBucket

[Styerp]

Cloning #25368
Closes #23940
Closes #4323

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[Styerp]

Reposting #25368 (comment)

API surface changes says changes would cause builds to fail -- that will not happen here. Underlying objects didn't access Bucket methods on the object passed into this function, either directly or indirectly. All properties and objects being used were already available on the IBucket, which was the driving rationale to ease this input type.

While this is ostensibly an API Surface Change, it is NOT a breaking surface change.

Behavior changes say "even though the user didn't change their code, the CloudFormation template that gets synthesized is now different." The integration tests prove this is not the case -- the CFN generated is identical.

Build will continue to fail because of the "Breaking API Changes". Guidance on how y'all handle this would be great. Clarification Request

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[mrgrain]

@rix0rrr Any idea why jsii-diff would be failing here:

API elements with incompatible changes:
err  - PROP aws-cdk-lib.aws_lambda_event_sources.S3EventSource.bucket: type aws-cdk-lib.aws_s3.IBucket (formerly aws-cdk-lib.aws_s3.Bucket): aws-cdk-lib.aws_s3.IBucket does not extend aws-cdk-lib.aws_s3.Bucket [changed-type:aws-cdk-lib.aws_lambda_event_sources.S3EventSource.bucket]

This seems like an okay change to me.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: c6ff065
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[otaviomacedo]

@rix0rrr Any idea why jsii-diff would be failing here:

API elements with incompatible changes:
err  - PROP aws-cdk-lib.aws_lambda_event_sources.S3EventSource.bucket: type aws-cdk-lib.aws_s3.IBucket (formerly aws-cdk-lib.aws_s3.Bucket): aws-cdk-lib.aws_s3.IBucket does not extend aws-cdk-lib.aws_s3.Bucket [changed-type:aws-cdk-lib.aws_lambda_event_sources.S3EventSource.bucket]

This seems like an okay change to me.

The problem here is that bucket is not only a constructor argument, but also a public property. With this change, the following would break:

const bucket = new Bucket(...);
const source = new S3EventSource(bucket, ...);

source.bucket.addCorsRule(...); // <-- Consumers expect this to be a Bucket

I'm not sure if there's a valid use case for accessing the bucket property like this (it was probably made public by accident). But technically, it's a breaking change.

[aws-cdk-automation]

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

[aws-cdk-automation]

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.