feat(cli): logging can be corked

[kaizencc]

🍾

This PR extends #25536 by fixing issues with logging.

• Asset building and publishing are now completely separate tasks, so there is never a need for the "Building and Publishing" message in cdk-assets. I've removed a good chunk of unnecessary private props in AssetPublisher and now we simply print Building when building an asset and Publishing when publishing an asset. No combos anymore.
• Asset build/publish can now happen concurrently with stack deployments when there are no dependencies between the two, but if --require-approval is set (which it is by default), sensitive stack deployments prompt the user for a y/n response before deployment. Additional asset related messages may come in at this time, cluttering the log. The solution here is to implement a cork that is turned on when prompting the user and turned off after user input. When using the helper function withCorkedLogging(callback), logs will instead be stored in memory and released when the cork is popped.

Testing:

There's not a great way to test these changes in code since they should only affect logging. Instead, I hope the following photos suffice:

Before the lock change, logging looked like this:

Now it looks like this in the same scenario:

The screenshots also show the logs that say Building and Publishing separately rather than Building and Publishing as it did before.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[kaizencc]

this is almost certainly the hackiest thing i've ever come up with. whats the better way to do something like this?

[kaizencc]

ok i thought of a better way immediately lol

[rix0rrr]

I like the solution! Needs some changes before it can be merged but conditionally approved

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: b86faef
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).