Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apigateway): add grantExecute to API Methods #25630

Merged
merged 3 commits into from
May 19, 2023
Merged

Conversation

otaviomacedo
Copy link
Contributor

To grant permission to a user:

const books = api.root.addResource('books');
books.grantExecute(user);

Closes #5198.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 17, 2023

@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 labels May 17, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team May 17, 2023 10:49
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 17, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 17, 2023
@mergify
Copy link
Contributor

mergify bot commented May 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a04d673
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit ecb59fd into main May 19, 2023
7 checks passed
@mergify mergify bot deleted the otaviom/grant-execute branch May 19, 2023 18:57
@mergify
Copy link
Contributor

mergify bot commented May 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@florianbepunkt
Copy link

florianbepunkt commented Jul 21, 2023

@otaviomacedo Has this been reverted? I'm on cdk v 2.88.0 (build 5d497f9) and for your example above I get Property 'grantExecute' does not exist on type 'Resource'.ts(2339)

EDIT: Never mind. Example was incomplete. The methods exists on the Method construct (not the Resource). Full example is:

const books = api.root.addResource("books");
const method = books.addMethod("POST", {....})
method.grantExecute(user);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[apigateway] grant() methods for IAM authorization
4 participants