Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(msk): Kafka version 3.4.0 #25557

Merged
merged 5 commits into from May 16, 2023
Merged

feat(msk): Kafka version 3.4.0 #25557

merged 5 commits into from May 16, 2023

Conversation

daschaa
Copy link
Contributor

@daschaa daschaa commented May 12, 2023

Closes #25522

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 12, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team May 12, 2023 11:33
@github-actions github-actions bot added star-contributor [Pilot] contributed between 25-49 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels May 12, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes May 12, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@daschaa daschaa changed the title (msk): add support for Kafka version 3.4.0 feat(msk): add support for Kafka version 3.4.0 May 12, 2023
@daschaa daschaa marked this pull request as ready for review May 12, 2023 16:43
@daschaa
Copy link
Contributor Author

daschaa commented May 12, 2023

Exemption Request: I think that this PR does not need a change to the README file.

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels May 12, 2023
@kaizencc kaizencc changed the title feat(msk): add support for Kafka version 3.4.0 feat(msk): Kafka version 3.4.0 May 15, 2023
kaizencc
kaizencc previously requested changes May 15, 2023
View reviewed changes
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments based on the integ test. we have a new system for integ tests after the repo restructure

...ster.js.snapshot/.cache/40aa87cdf43c4095cec18bc443965f22ab2f8c1ace47e482a0ba4e35d83b0cc9.zip Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-msk-alpha/test/integ.cluster-version.ts Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 15, 2023
@kaizencc kaizencc added pr-linter/exempt-readme The PR linter will not require README changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels May 15, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review May 15, 2023 19:04

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify mergify bot dismissed kaizencc’s stale review May 16, 2023 16:03

Pull request has been modified.

@daschaa
Copy link
Contributor Author

daschaa commented May 16, 2023

@kaizencc I have removed the cached files. I would appreciate a re-review :) Thanks in advance!

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 16, 2023
@mergify
Copy link
Contributor

mergify bot commented May 16, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 16, 2023
@mergify
Copy link
Contributor

mergify bot commented May 16, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f774bec
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 6317518 into aws:main May 16, 2023
7 checks passed
@mergify
Copy link
Contributor

mergify bot commented May 16, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaizencc kaizencc kaizencc approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr-linter/exempt-readme The PR linter will not require README changes star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(msk): Support for Apache Kafka version 3.4.0
3 participants
@daschaa @aws-cdk-automation @kaizencc