Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(s3-deployment): add some convenient methods to CacheControl #25477

Merged
merged 2 commits into from
May 25, 2023
Merged

feat(s3-deployment): add some convenient methods to CacheControl #25477

merged 2 commits into from
May 25, 2023

Conversation

Tietew
Copy link
Contributor

@Tietew Tietew commented May 8, 2023

This PR adds following convenient methods to CacheControl.

method directive RFC
CacheControl.noStore() no-store RFC9111, Section 5.2.2.4
CacheControl.mustUnderstand() must-understand RFC9111, Section 5.2.2.3
CacheControl.immutable() immutable RFC8246
CacheControl.staleWhileRevalidate(duration) stale-while-revalidate=<duration> RFC5861
CacheControl.staleIfError(duration) stale-if-error=<duration> RFC5861

For more information about these Cache-Control directives,
see https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 8, 2023

@github-actions github-actions bot added the p2 label May 8, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team May 8, 2023 06:26
@github-actions github-actions bot added the valued-contributor [Pilot] contributed between 6-12 PRs to the CDK label May 8, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes May 8, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@Tietew
Copy link
Contributor Author

Tietew commented May 8, 2023

Exemption Request

There are no integration tests for CacheControl directives.

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels May 8, 2023
corymhall
corymhall previously approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@corymhall corymhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@corymhall corymhall added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label May 24, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review May 24, 2023 10:05

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 24, 2023
@mergify
Copy link
Contributor

mergify bot commented May 24, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@Tietew
Copy link
Contributor Author

Tietew commented May 24, 2023

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented May 24, 2023

update

❌ Base branch update has failed

refusing to allow a GitHub App to create or update workflow .github/workflows/github-merit-badger.yml without workflows permission
err-code: E943C

@Tietew
Copy link
Contributor Author

Tietew commented May 25, 2023

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented May 25, 2023

update

❌ Base branch update has failed

refusing to allow a GitHub App to create or update workflow .github/workflows/github-merit-badger.yml without workflows permission
err-code: F5032

@mergify mergify bot dismissed corymhall’s stale review May 25, 2023 10:08

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ee5920c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 25, 2023
@mergify
Copy link
Contributor

mergify bot commented May 25, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 21fc1d1 into aws:main May 25, 2023
9 checks passed
@Tietew Tietew deleted the s3-deployment-cachecontrol-methods branch May 25, 2023 11:10
@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
@Tietew Tietew mentioned this pull request Dec 26, 2023
Merged
mergify bot pushed a commit that referenced this pull request Dec 30, 2023
@Tietew
feat(codepipeline-actions): more convenient methods to CacheControl (…
a59dc0c 
…#28491)

This PR adds following convenient methods to `CacheControl`; same as #25477.

| method | directive | RFC |
|-|-|-|
| `CacheControl.noStore()` | `no-store` | [RFC9111](https://www.rfc-editor.org/rfc/rfc9111.html), Section 5.2.2.4 |
| `CacheControl.mustUnderstand()` | `must-understand` | RFC9111, Section 5.2.2.3 |
| `CacheControl.immutable()` | `immutable` | [RFC8246](https://www.rfc-editor.org/rfc/rfc8246.html) |
| `CacheControl.staleWhileRevalidate(duration)` | `stale-while-revalidate=<duration>` | [RFC5861](https://www.rfc-editor.org/rfc/rfc5861.html) |
| `CacheControl.staleIfError(duration)` | `stale-if-error=<duration>` | RFC5861 |

For more information about these Cache-Control directives,
see https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
paulhcsun pushed a commit to paulhcsun/aws-cdk that referenced this pull request Jan 5, 2024
@Tietew @paulhcsun
feat(codepipeline-actions): more convenient methods to CacheControl (…
366a946 
…aws#28491)

This PR adds following convenient methods to `CacheControl`; same as aws#25477.

| method | directive | RFC |
|-|-|-|
| `CacheControl.noStore()` | `no-store` | [RFC9111](https://www.rfc-editor.org/rfc/rfc9111.html), Section 5.2.2.4 |
| `CacheControl.mustUnderstand()` | `must-understand` | RFC9111, Section 5.2.2.3 |
| `CacheControl.immutable()` | `immutable` | [RFC8246](https://www.rfc-editor.org/rfc/rfc8246.html) |
| `CacheControl.staleWhileRevalidate(duration)` | `stale-while-revalidate=<duration>` | [RFC5861](https://www.rfc-editor.org/rfc/rfc5861.html) |
| `CacheControl.staleIfError(duration)` | `stale-if-error=<duration>` | RFC5861 |

For more information about these Cache-Control directives,
see https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corymhall corymhall corymhall approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tietew @aws-cdk-automation @corymhall