Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecr): grantRead on repositories #25445

Merged
merged 5 commits into from
May 5, 2023
Merged

feat(ecr): grantRead on repositories #25445

merged 5 commits into from
May 5, 2023

Conversation

kaizencc
Copy link
Contributor

@kaizencc kaizencc commented May 4, 2023

Adds a grantRead method with ecr:DescribeRepositories and ecr:DescribeImages permissions.

The use case is for something like cdk-assets, which tries to look up the repository / image name as part of the publishing step (so it doesn't publish a duplicate).


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 4, 2023

@github-actions github-actions bot added the p2 label May 4, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team May 4, 2023 20:12
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 4, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@kaizencc kaizencc added the pr-linter/exempt-readme The PR linter will not require README changes label May 4, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review May 4, 2023 21:41

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 4, 2023
@mergify
Copy link
Contributor

mergify bot commented May 5, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: adc7cd2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit ce7bdea into main May 5, 2023
7 checks passed
@mergify mergify bot deleted the conroy/grant branch May 5, 2023 15:10
@mergify
Copy link
Contributor

mergify bot commented May 5, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants