Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eks: Update AlbControllerVersions to add missing versions between 2.4.1 and 2.5.x #25307

Closed
2 tasks
arlampin opened this issue Apr 26, 2023 · 3 comments · Fixed by #25330
Closed
2 tasks

eks: Update AlbControllerVersions to add missing versions between 2.4.1 and 2.5.x #25307

arlampin opened this issue Apr 26, 2023 · 3 comments · Fixed by #25330
Assignees
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@arlampin
Copy link

Describe the feature

aws-eks' build-in support for AWS Load Balancer Controller has only versions up to 2.4.1 (released in March 2022). Releases 2.4.2->2.5.1 releases and their associated policies are missing.

Release list: https://github.com/kubernetes-sigs/aws-load-balancer-controller/releases

Use Case

I would like to use a newer controller version without manual configuration.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.76.0

Environment details (OS name and version, etc.)

N/A

@arlampin arlampin added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 26, 2023
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Apr 26, 2023
@pahud
Copy link
Contributor

pahud commented Apr 26, 2023

We can add the versions in the enum-like class here:

export class AlbControllerVersion {

Any PRs are welcome and appreciated!

@pahud pahud added p2 good first issue Related to contributions. See CONTRIBUTING.md effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Apr 26, 2023
@colifran colifran self-assigned this Apr 26, 2023
@mergify mergify bot closed this as completed in #25330 May 15, 2023
@mergify mergify bot closed this as completed in 83c4c36 May 15, 2023
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

1 similar comment
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants