feat(ecr): add option to auto delete images upon ECR repository removal #24572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inesis event source to be able to validate the eventId is created and defined at time of binding
github-actions
bot
added
the
beginning-contributor
aws-cdk-automation
previously requested changes
Mar 10, 2023
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
randyridgley
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
MrArnoldPalmer
previously requested changes
Mar 21, 2023
packages/@aws-cdk/aws-ecr/lib/auto-delete-images-handler/index.ts
Outdated
Show resolved
Hide resolved
…al. Updates based on PR review
mergify
bot
dismissed
MrArnoldPalmer’s stale review
Pull request has been modified.
MrArnoldPalmer
previously requested changes
Mar 21, 2023
Co-authored-by: Mitchell Valine <mitchellvaline@gmail.com>
mergify
bot
dismissed
MrArnoldPalmer’s stale review
Pull request has been modified.
MrArnoldPalmer
approved these changes
Mar 21, 2023
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
homakk
pushed a commit
to homakk/aws-cdk
that referenced
this pull request
Mar 28, 2023
…al (aws#24572) This request fixes the ECR Repository resource to allow setting a flag on the resource to auto delete the images in the repository. This is similar to the way S3 handles the autoDeleteObjects attribute. This code base starts from a stalled PR [aws#15932](aws#15932). This also takes into account the functionality added into S3 to create tag to not delete images if the flag is flipped from true to false. Closes [aws#12618](aws#12618) References closed and not merged PR [aws#15932](aws#15932) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot
pushed a commit
to CloudSnorkel/cdk-github-runners
that referenced
this pull request
Nov 30, 2023
…r us (#476) AWS Image Builder [recently introduced lifecycle rules](https://aws.amazon.com/about-aws/whats-new/2023/11/ec2-image-builder-lifecycle-management-deletion/) that can help us remove old images from EC2/ECR, and their descriptors on AWS Image Builder side. CDK [added automatic deletion of images in repositories](aws/aws-cdk#24572) so they can be deleted in CloudFormation easily. We had a custom resource to delete images, but now we can just use `autoDeleteImages`. We still have to clean-up AWS Image Builder image descriptors and AMIs with a custom resource. We do this so removing our construct won't leave anything behind. Resolves #471 BREAKING CHANGE: CDK 2.110.0 and above is required
mergify bot
pushed a commit
that referenced
this pull request
Dec 19, 2023
… construct (#28233) Added `emptyOnDelete` prop to the ecr `Repository` construct. `emptyOndelete` is supported by CloudFormation See here: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ecr-repository.html#cfn-ecr-repository-emptyondelete I've also deprecated the `autoDeleteImages` prop that deployed a custom resource. According to #24572 this was added before CloudFormation added the `EmptyOnDelete` property here aws-cloudformation/cloudformation-coverage-roadmap#515 Closes #28196 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request fixes the ECR Repository resource to allow setting a flag on the resource to auto delete the images in the repository. This is similar to the way S3 handles the autoDeleteObjects attribute. This code base starts from a stalled PR #15932. This also takes into account the functionality added into S3 to create tag to not delete images if the flag is flipped from true to false.
Closes #12618
References closed and not merged PR #15932
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license