Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(codepipeline-actions): add KMSEncryptionKeyARN for S3DeployAction #24536

Merged
merged 68 commits into from May 18, 2023
Merged

feat(codepipeline-actions): add KMSEncryptionKeyARN for S3DeployAction #24536

merged 68 commits into from May 18, 2023

Conversation

hussainak
Copy link
Contributor

Add KMSEncryptionKeyARN for S3DeployAction

Closes #24535.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@hussainak
Add KMSEncryptionKeyARN
3260703 
Added KMSEncryptionKeyARN
@aws-cdk-automation aws-cdk-automation requested a review from a team March 9, 2023 02:49
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 labels Mar 9, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@hussainak
Copy link
Contributor Author

Exemption Request

I think this is a very minor enhancement and not exactly a full blown feature. Something between a bug and a feature.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Mar 9, 2023
@hussainak
Copy link
Contributor Author

hussainak commented Mar 9, 2023 •
edited

Exemption Request

I don't have a personal AWS account to test (integration test) this. Please test on my behalf.

TheRealAmazonKendra
TheRealAmazonKendra previously requested changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I have a couple of comments inline. In regard to the test, please write the test case and then we'll run it and update the snapshots.

packages/@aws-cdk/aws-codepipeline-actions/lib/s3/deploy-action.ts Outdated
* For a KMS key, you can use the key ID, the key ARN, or the alias ARN.
* @default - none
*/
readonly kmsEncryptionKeyArn?: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than this being an ARN, we should be taking in an IKey here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Kendra, Thanks for reviewing this :)

I have updated the code.

README.md Outdated
@@ -1,178 +1,1234 @@
# AWS Cloud Development Kit (AWS CDK)
# AWS CodePipeline Actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like an unintentional change. Our root level README shouldn't be edited on this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi again!

I have undone the changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The root level README is still changed. Looks like the updates were made in the wrong README.

Copy link
Contributor Author

@hussainak hussainak Mar 13, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi again Kendra.. Yea it has confused me on how that went in but I have rolled back the changes now.

@TheRealAmazonKendra TheRealAmazonKendra added pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Mar 9, 2023
@TheRealAmazonKendra
Copy link
Contributor

Adding exemption for snapshot changes. We'll do those. We still need the test case written, though.

@aws-cdk-automation aws-cdk-automation dismissed their stale review March 9, 2023 17:22

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@mergify mergify bot dismissed TheRealAmazonKendra’s stale review March 9, 2023 22:54

Pull request has been modified.

@hussainak
Copy link
Contributor Author

Thank you for your contribution! I have a couple of comments inline. In regard to the test, please write the test case and then we'll run it and update the snapshots.

Hi Kendra!

I have added the test you mentioned, please let me know if it needs any changes.

@hussainak hussainak removed the request for review from aws-cdk-automation March 10, 2023 00:48
@hussainak
Copy link
Contributor Author

A short note: you have a PR marked feat, that implies you should make README changes. Also, never hurts to throw in the why when asking for an Exemption Request

68747470733a2f2f6d656469612e74656e6f722e636f6d2f776d693772643541727730414141414d2f637269746963616c2d726f6c652d63722e676966

Can this PR be reviewed and merged please

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 8, 2023
@mergify
Copy link
Contributor

mergify bot commented May 18, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 18, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3835769
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit b60876f into aws:main May 18, 2023
9 checks passed
@mergify
Copy link
Contributor

mergify bot commented May 18, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
@tam0ri tam0ri mentioned this pull request Aug 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otaviomacedo otaviomacedo otaviomacedo approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

@TheRealAmazonKendra TheRealAmazonKendra Awaiting requested review from TheRealAmazonKendra

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@aws-cdk-lib/aws-codepipeline-actions: KMS encryption key needed for S3DeployAction
5 participants
@hussainak @TheRealAmazonKendra @aws-cdk-automation @Naumel @otaviomacedo