Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rds): PostgreSQL engine version 15.2 #24463

Merged
merged 2 commits into from Mar 9, 2023
Merged

feat(rds): PostgreSQL engine version 15.2 #24463

merged 2 commits into from Mar 9, 2023

Conversation

klausbadelt
Copy link
Contributor

RDS supports PostgreSQL engine version 15.2, but the PostgresEngineVersion.VER_15_2 constant is not implemented yet. The current CDK version only lists up to VER_14_6.

aws rds describe-db-engine-versions --engine postgres | jq -r '.DBEngineVersions[] | [.EngineVersion]' | grep "15\."
  "15.2"

Use Case

new DatabaseInstance(this, 'PostgresDatabase',  
  engine: DatabaseInstanceEngine.postgres({ version: PostgresEngineVersion.VER_15_2 }),
)

Closes #24462.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 labels Mar 5, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team March 5, 2023 20:29
comcalvi
comcalvi previously requested changes Mar 6, 2023
View reviewed changes
packages/@aws-cdk/aws-rds/lib/instance-engine.ts
Comment on lines +1052 to +1053
/** Version "15.2". */
public static readonly VER_15_2 = PostgresEngineVersion.of('15.2', '15', { s3Import: true, s3Export: true });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if there's a 15.2, there must be a 15.1. Could we add that one as well?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

15.2 is the first minor version of PostgreSQL 15 supported by RDS
https://docs.aws.amazon.com/AmazonRDS/latest/PostgreSQLReleaseNotes/postgresql-versions.html#postgresql-versions-version15

@kaizencc kaizencc changed the title chore(rds): add additional PostgreSQL engine version 15.2 feat(rds): PostgreSQL engine version 15.2 Mar 9, 2023
@kaizencc kaizencc added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Mar 9, 2023
@github-actions github-actions bot added the effort/small Small work item – less than a day of effort label Mar 9, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 9, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5895a62
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 59d795b into aws:main Mar 9, 2023
5 checks passed
@mergify
Copy link
Contributor

mergify bot commented Mar 9, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

homakk pushed a commit to homakk/aws-cdk that referenced this pull request Mar 28, 2023
@klausbadelt @homakk
feat(rds): PostgreSQL engine version 15.2 (aws#24463)
b3c97f0 
RDS supports PostgreSQL engine version 15.2, but the `PostgresEngineVersion.VER_15_2` constant  is not implemented yet. The current CDK version only lists up to `VER_14_6`.

```sh
aws rds describe-db-engine-versions --engine postgres | jq -r '.DBEngineVersions[] | [.EngineVersion]' | grep "15\."
  "15.2"
```

### Use Case

```js
new DatabaseInstance(this, 'PostgresDatabase',  
  engine: DatabaseInstanceEngine.postgres({ version: PostgresEngineVersion.VER_15_2 }),
)
```

Closes aws#24462.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstrand rstrand rstrand left review comments

@kaizencc kaizencc kaizencc approved these changes

@comcalvi comcalvi comcalvi left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat (rds): PostgreSQL engine version 15.2
5 participants
@klausbadelt @aws-cdk-automation @rstrand @kaizencc @comcalvi