Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-eks: Support EKS 1.25 #24282

Closed
plumdog opened this issue Feb 22, 2023 · 5 comments · Fixed by #24484
Closed

aws-eks: Support EKS 1.25 #24282

plumdog opened this issue Feb 22, 2023 · 5 comments · Fixed by #24484
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1

Comments

@plumdog
Copy link
Contributor

plumdog commented Feb 22, 2023

Describe the feature

1.25 is now listed here https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html#kubernetes-1.25

I think it only landed today, but I can't find an announcement.

I guess this will also need a package from https://github.com/cdklabs/awscdk-asset-kubectl to support 1.25.

@plumdog plumdog added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 22, 2023
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Feb 22, 2023
@khushail
Copy link
Contributor

Hi @plumdog , Thanks for sharing the latest update on Kubernetes.

For now, I would be marking this as P1. I would reach out to my team for getting updates on latest package inclusion and share the same with you.

@khushail khushail added p1 and removed needs-triage This issue or PR still needs to be triaged. labels Feb 22, 2023
@khushail khushail self-assigned this Feb 22, 2023
@khushail khushail added the effort/medium Medium work item – several days of effort label Feb 22, 2023
@khushail khushail removed their assignment Feb 23, 2023
@pahud
Copy link
Contributor

pahud commented Feb 23, 2023

Yeah. Before we get 1.25 layer cdklabs/awscdk-asset-kubectl#166 I just tested we still can deploy 1.25 cluster like this.

Please note - using 1.24 kubectl with 1.25 cluster might have some issues.

import { App, Stack, StackProps,
  aws_eks as eks,
  aws_ec2 as ec2 } from 'aws-cdk-lib';
  import { KubectlV24Layer as KubectlLayer } from '@aws-cdk/lambda-layer-kubectl-v24';
  
  import { Construct } from 'constructs';
  
  export class EksTsStack extends Stack {
    constructor(scope: Construct, id: string, props: StackProps = {}) {
      super(scope, id, props);
  
      const vpc = ec2.Vpc.fromLookup(this, 'Vpc', { isDefault: true });
      new eks.Cluster(this, 'Cluster', {
        vpc,
        version: eks.KubernetesVersion.of('1.25'),
        kubectlLayer: new KubectlLayer(this, 'KubectlLayer'),
      })
    }
  }

$ kubectl get no
NAME STATUS ROLES AGE VERSION
ip-172-31-12-128.us-west-2.compute.internal Ready 5m9s v1.25.6-eks-48e63af
ip-172-31-14-191.us-west-2.compute.internal Ready 5m9s v1.25.6-eks-48e63af

$ kubectl -n kube-system get po
NAME READY STATUS RESTARTS AGE
aws-node-4cltv 1/1 Running 0 5m24s
aws-node-9q2zb 1/1 Running 0 5m24s
coredns-67f8f59c6c-gh6lt 1/1 Running 0 11m
coredns-67f8f59c6c-tclrd 1/1 Running 0 11m
kube-proxy-5l89h 1/1 Running 0 5m24s
kube-proxy-rwbl2 1/1 Running 0 5m24s

@AlyIbrahim
Copy link

Yes, but I think it is always better to work with kubectl version that matches the Kubernetes cluster version

@plumdog
Copy link
Contributor Author

plumdog commented Feb 27, 2023

You should expect kubectl 1.24 to work with EKS 1.25 without issue because kubectl has a +/-1 minor version skew policy, per https://kubernetes.io/releases/version-skew-policy/#kubectl.

But clearly there ought to be a CDK kubectl layer for 1.25 before the CDK's support for 1.25 could be considered "done".

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

homakk pushed a commit to homakk/aws-cdk that referenced this issue Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants