Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docdb): added ability to enable performance insights #24039

Merged
merged 8 commits into from Mar 8, 2023

Conversation

rodrigomata
Copy link
Contributor

Added the ability to enable performance insights in the L2 construct for DocumentDB Cluster so it can be enabled programmatically in all instances inside the cluster.

Closes #24036.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Feb 6, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team February 6, 2023 17:45
@github-actions github-actions bot added feature-request A feature should be added or improved. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Feb 6, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@rodrigomata rodrigomata changed the title feat(aws-docdb): added ability to enable performance insights feat(docdb): added ability to enable performance insights Feb 6, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 6, 2023 18:07

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall, but from the looks of it, there are not enough changes in the integ test snapshot output for this to have been run. Was this manually updated? Please remove the manual update from the snapshot and run this with yarn integ --update-on-failed.

@mergify mergify bot dismissed TheRealAmazonKendra’s stale review February 10, 2023 17:27

Pull request has been modified.

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@rodrigomata
Copy link
Contributor Author

This looks good overall, but from the looks of it, there are not enough changes in the integ test snapshot output for this to have been run. Was this manually updated? Please remove the manual update from the snapshot and run this with yarn integ --update-on-failed.

I removed the manual update and ran the yarn integ --update-on-failed command; however, nothing changed after running it and after committing the change the pipeline breaks, am I missing something? Read throughout the contributing and integration tests section but couldn't find anything related

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@MrArnoldPalmer
Copy link
Contributor

Hey @rodrigomata , so there are integ test snapshot changes that result from the change you've added. I don't have permissions to push to your fork, so I can't add the commit with the update here, you can enable changes to your fork for upstream maintainers so I can push the updates, or you can apply the commit yourself from here.

@rodrigomata
Copy link
Contributor Author

Hey @rodrigomata , so there are integ test snapshot changes that result from the change you've added. I don't have permissions to push to your fork, so I can't add the commit with the update here, you can enable changes to your fork for upstream maintainers so I can push the updates, or you can apply the commit yourself from here.

Thanks for replying @MrArnoldPalmer and adding what was missing. Strange because the permissions were enabled but probably a bug on Github, so I disabled and re-enabled hoping it made some effect so you can push the commits you already have there:

Screenshot 2023-03-08 at 13 55 24

@MrArnoldPalmer
Copy link
Contributor

ahh I may have been trying to push the wrong branch actually, no worries working now.

@aws-cdk-automation aws-cdk-automation dismissed their stale review March 8, 2023 20:45

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Mar 8, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 607f222
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c897f44 into aws:main Mar 8, 2023
5 checks passed
@mergify
Copy link
Contributor

mergify bot commented Mar 8, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

homakk pushed a commit to homakk/aws-cdk that referenced this pull request Mar 28, 2023
Added the ability to enable performance insights in the L2 construct for DocumentDB Cluster so it can be enabled programmatically in all instances inside the cluster.

> [CONTRIBUTING GUIDE]: https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md
> [DESIGN GUIDELINES]: https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md

Closes aws#24036.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-cdk-lib/doc-db: Add option to enable performance insights in instances
5 participants