Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-cdk-lib/doc-db: Add option to enable performance insights in instances #24036

Closed
1 of 2 tasks
rodrigomata opened this issue Feb 6, 2023 · 2 comments · Fixed by #24039
Closed
1 of 2 tasks

aws-cdk-lib/doc-db: Add option to enable performance insights in instances #24036

rodrigomata opened this issue Feb 6, 2023 · 2 comments · Fixed by #24039
Labels
@aws-cdk/aws-cloudformation Related to AWS CloudFormation effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@rodrigomata
Copy link
Contributor

Describe the feature

It would be great if there is an option to enable performance insights when creating a cluster with the L2 construct available for DocumentDb.

Use Case

This will help to automate the process of when creating instances, enable the performance insights on them.

Proposed Solution

I see in the DocumentDB Instance cloudformation documentation that it just needs a boolean parameter at the instance level.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.63.0

Environment details (OS name and version, etc.)

macOS Ventura 13.1
@rodrigomata rodrigomata added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 6, 2023
@github-actions github-actions bot added the @aws-cdk/aws-cloudformation Related to AWS CloudFormation label Feb 6, 2023
@rodrigomata rodrigomata mentioned this issue Feb 6, 2023
Merged
@pahud
Copy link
Contributor

pahud commented Feb 6, 2023

Thank you for your PR contribution!

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Feb 6, 2023
@mergify mergify bot closed this as completed in #24039 Mar 8, 2023
mergify bot pushed a commit that referenced this issue Mar 8, 2023
@rodrigomata
feat(docdb): added ability to enable performance insights (#24039)
c897f44 
Added the ability to enable performance insights in the L2 construct for DocumentDB Cluster so it can be enabled programmatically in all instances inside the cluster.

> [CONTRIBUTING GUIDE]: https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md
> [DESIGN GUIDELINES]: https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md

Closes #24036.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

homakk pushed a commit to homakk/aws-cdk that referenced this issue Mar 28, 2023
@rodrigomata @homakk
feat(docdb): added ability to enable performance insights (aws#24039)
bf2d11f 
Added the ability to enable performance insights in the L2 construct for DocumentDB Cluster so it can be enabled programmatically in all instances inside the cluster.

> [CONTRIBUTING GUIDE]: https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md
> [DESIGN GUIDELINES]: https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md

Closes aws#24036.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-cloudformation Related to AWS CloudFormation effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(docdb): added ability to enable performance insights rodrigomata/aws-cdk
2 participants
@pahud @rodrigomata