Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-ec2): Support configuring credit specification on NAT instance #19166

Closed
2 tasks
leftiness opened this issue Feb 25, 2022 · 2 comments · Fixed by #28728
Closed
2 tasks

(aws-ec2): Support configuring credit specification on NAT instance #19166

leftiness opened this issue Feb 25, 2022 · 2 comments · Fixed by #28728
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@leftiness
Copy link

Description

Support configuring credit specification on NAT instance.

Use Case

I want to deploy a NAT instance with standard credit specification. The default for t4g.nano is unlimited.

Proposed Solution

Pass a creditSpecification property from NatInstanceProvider down to CfnInstance.

Other information

idea

  • Add a creditSpecification property to NatInstanceProps for NatInstanceProvider.
  • Add a creditSpecification property to InstanceProps for Instance.
  • Use the existing creditSpecification property on CfnInstanceProps for CfnInstance.

links

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@leftiness leftiness added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 25, 2022
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Feb 25, 2022
@corymhall
Copy link
Contributor

I am unassigning and marking this issue as p2, which means that we are unable to work on this immediately.

We use +1s to help prioritize our work, and are happy to revaluate this issue based on community feedback. You can reach out to the cdk.dev community on Slack to solicit support for reprioritization.

@corymhall corymhall added effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Feb 28, 2022
@corymhall corymhall removed their assignment Feb 28, 2022
@badmintoncryer badmintoncryer mentioned this issue Jan 16, 2024
Merged
@mergify mergify bot closed this as completed in #28728 Feb 29, 2024
mergify bot pushed a commit that referenced this issue Feb 29, 2024
@badmintoncryer
feat(ec2): support for the credit configuration mode for burstable in…
3cbad4a 
…stances (#28728)

In this PR, I have enabled the setting of the [credit configuration mode](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/burstable-credits-baseline-concepts.html#key-concepts) for EC2 instances and NAT instances in burstable performance instances.

```ts
// for EC2 instance
new Instance(stack, 'Instance', {
  vpc,
  machineImage: new AmazonLinuxImage(),
  instanceType: InstanceType.of(InstanceClass.T3, InstanceSize.LARGE),
  creditSpecification: CpuCredits.STANDARD, // added
});

// for NAT instance
const natInstanceProvider = NatProvider.instance({
  instanceType: InstanceType.of(InstanceClass.T3, InstanceSize.LARGE),
  machineImage: new AmazonLinuxImage(),
  creditSpecification: CpuCredits.STANDARD, // added
});
new Vpc(stack, 'VPC', {
  natGatewayProvider: natInstanceProvider,
});
```

Closes #19166.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ec2): support for the credit configuration mode for burstable instances badmintoncryer/aws-cdk
3 participants
@leftiness @MrArnoldPalmer @corymhall