fix(cli): cannot set progress
via app or user configuration
#231
+41
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v2.172.0 (via aws/aws-cdk@069b72c) we accidentally broke the "bar" stack activity progress output mode (*). Turns out no-one noticed.
In v2.1002.0 (via 0d9912f) this got unintentionally fixed and the
--progress
was honored again. However the accidental fix didn't consider options set by app or user configuration. Again this went unnoticed for a while, until this week a user alerted my to the issue on the cdk.dev Slack.This PR fixes
progress
set via app or user configuration.(*) This line is the culprit:
aws/aws-cdk@069b72c#diff-d03bd87f399ba5824d5442aa691df8b6f08f4f8a3848cfc8492c3d52fab5e48bR105
Previously "default" verbosity was a
0
, which meantverbose = 0
and later on!verbose
would turn intotrue
.The change caused
verbose
to be a value different than0
and thus turning!verbose
to befalse
and the code would always assume we are in verbose logging mode and must use the "events" progress.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license