Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): cannot set progress via app or user configuration #231

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Mar 13, 2025

In v2.172.0 (via aws/aws-cdk@069b72c) we accidentally broke the "bar" stack activity progress output mode (*). Turns out no-one noticed.

In v2.1002.0 (via 0d9912f) this got unintentionally fixed and the --progress was honored again. However the accidental fix didn't consider options set by app or user configuration. Again this went unnoticed for a while, until this week a user alerted my to the issue on the cdk.dev Slack.

This PR fixes progress set via app or user configuration.

(*) This line is the culprit:
aws/aws-cdk@069b72c#diff-d03bd87f399ba5824d5442aa691df8b6f08f4f8a3848cfc8492c3d52fab5e48bR105
Previously "default" verbosity was a 0, which meant verbose = 0 and later on !verbose would turn into true.
The change caused verbose to be a value different than 0 and thus turning !verbose to be false and the code would always assume we are in verbose logging mode and must use the "events" progress.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Mar 13, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 13, 2025 20:45
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.05%. Comparing base (3791941) to head (6cf585f).

Files with missing lines Patch % Lines
packages/aws-cdk/lib/cli/cdk-toolkit.ts 50.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
+ Coverage   84.88%   85.05%   +0.16%     
==========================================
  Files         208      208              
  Lines       35680    35690      +10     
  Branches     4616     4625       +9     
==========================================
+ Hits        30287    30355      +68     
+ Misses       5247     5185      -62     
- Partials      146      150       +4     
Flag Coverage Δ
suite.unit 85.05% <50.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrgrain mrgrain changed the title fix(cli): cannot set progress via app or user configuration fix(cli): cannot set progress via app or user configuration Mar 14, 2025

Verified

This commit was signed with the committer’s verified signature.
kzaher Krunoslav Zaher
@mrgrain mrgrain marked this pull request as ready for review March 14, 2025 09:25
@mrgrain mrgrain force-pushed the mrgrain/fix/progress-option-not-honoured branch from f4ce9d9 to 6cf585f Compare March 14, 2025 09:25
@mrgrain mrgrain temporarily deployed to integ-approval March 14, 2025 09:25 — with GitHub Actions Inactive
@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Mar 14, 2025
Merged via the queue into main with commit 5631014 Mar 14, 2025
20 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/fix/progress-option-not-honoured branch March 14, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants