Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toolkit-lib): structured log monitoring events #218

Merged
merged 3 commits into from
Mar 11, 2025

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Mar 10, 2025

Moves more of the APIs to use modern IO infrastructure.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Mar 10, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 10, 2025 13:35
@mrgrain mrgrain force-pushed the mrgrain/feat/toolkit-lib/log-monitor-events branch from 2488620 to ceed328 Compare March 11, 2025 16:56
@mrgrain mrgrain force-pushed the mrgrain/feat/toolkit-lib/log-monitor-events branch from ceed328 to 4a32757 Compare March 11, 2025 17:03
@mrgrain mrgrain force-pushed the mrgrain/feat/toolkit-lib/log-monitor-events branch from 4a32757 to 7f39c01 Compare March 11, 2025 18:15
@mrgrain mrgrain force-pushed the mrgrain/feat/toolkit-lib/log-monitor-events branch from 7f39c01 to efa135b Compare March 11, 2025 18:16
@mrgrain mrgrain marked this pull request as ready for review March 11, 2025 18:16
@mrgrain mrgrain temporarily deployed to integ-approval March 11, 2025 19:41 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 83.72093% with 14 lines in your changes missing coverage. Please review.

Project coverage is 85.06%. Comparing base (84d0b54) to head (9e4745b).

Files with missing lines Patch % Lines
packages/aws-cdk/lib/api/logs/logs-monitor.ts 88.46% 9 Missing ⚠️
packages/aws-cdk/lib/cli/cdk-toolkit.ts 33.33% 4 Missing ⚠️
...kages/aws-cdk/lib/api/logs/find-cloudwatch-logs.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
+ Coverage   85.00%   85.06%   +0.05%     
==========================================
  Files         208      208              
  Lines       35563    35591      +28     
  Branches     4627     4623       -4     
==========================================
+ Hits        30230    30275      +45     
+ Misses       5175     5165      -10     
+ Partials      158      151       -7     
Flag Coverage Δ
suite.unit 85.06% <83.72%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: github-actions <github-actions@github.com>
@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Mar 11, 2025
Merged via the queue into main with commit 1bef263 Mar 11, 2025
20 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/feat/toolkit-lib/log-monitor-events branch March 11, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants