Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aws/aws-cdk-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cdk@v2.1002.0
Choose a base ref
...
head repository: aws/aws-cdk-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cdk@v2.1003.0
Choose a head ref
  • 19 commits
  • 169 files changed
  • 8 contributors

Commits on Mar 3, 2025

  1. chore: pr labeler workflow (#178)

    equivalent to this file in aws/aws-cdk except `auto-approve` is governed
    by projen already:
    https://github.com/aws/aws-cdk/blob/main/.github/workflows/pr-labeler.yml.
    will copy over labels from linked issues to the PR.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    
    ---------
    
    Signed-off-by: github-actions <github-actions@github.com>
    Co-authored-by: github-actions <github-actions@github.com>
    kaizencc and github-actions authored Mar 3, 2025
    Copy the full SHA
    f8d28e0 View commit details
  2. chore: mask bucket name in s3 docs publishing step (#182)

    Actually mask the bucket name in s3 docs publishing logs. This isn't a
    secret, so it's not bad. The logs for the one run that did accidentally
    print the name have already been deleted.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    mrgrain authored Mar 3, 2025
    Copy the full SHA
    48244a9 View commit details
  3. chore(adc): install dependencies before publishing (#181)

    Otherwise we can't find the AWS SDK dependencies that we need.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    
    ---------
    
    Signed-off-by: github-actions <github-actions@github.com>
    Co-authored-by: github-actions <github-actions@github.com>
    rix0rrr and github-actions authored Mar 3, 2025
    Copy the full SHA
    753f7f6 View commit details
  4. docs: remove -f option in CONTRIBUTING.md (#180)

    Fixes #
    
    In CONTRIBUTING.md, the command for running integration tests does not
    work:
    ```bash
    $ bin/run-suite -s ../../../../aws-cdk-cli cli-integ-tests -f 2.179.0-t 'cli-lib deploy'
    Error: Cannot use --framework-version with --use-source
        at main (/Users/t-takahashi/Documents/workspace/aws-cdk-cli-testing/packages/@aws-cdk-testing/cli-integ/lib/cli/run-suite.js:85:19)
    ```
    The `-f` option cannot be used with `-s`, so I removed `-f` from the
    snippet.
    
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    
    Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
    tttol and mrgrain authored Mar 3, 2025
    Copy the full SHA
    a294dbd View commit details
  5. chore(deps): upgrade dependencies (#179)

    Upgrades project dependencies. See details in [workflow run].
    
    [Workflow Run]:
    https://github.com/aws/aws-cdk-cli/actions/runs/13620811651
    
    ------
    
    *Automatically created by projen via the "upgrade" workflow*
    
    ---------
    
    Signed-off-by: github-actions <github-actions@github.com>
    Co-authored-by: github-actions <github-actions@github.com>
    aws-cdk-automation and github-actions authored Mar 3, 2025
    Copy the full SHA
    12299ff View commit details
  6. chore: change SSM timestamp name to cli-npm (#185)

    We used to publish under the key name `cli`, but the library publishing
    process is writing timestamps under `npm`, `pypi`, etc.
    
    Having the keys
    
    * `npm`
    * `pypi`
    * `nuget`
    * ...
    * `cli`
    
    Was confusing, so we're changing it to `cli-npm` instead.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    
    ---------
    
    Signed-off-by: github-actions <github-actions@github.com>
    Co-authored-by: github-actions <github-actions@github.com>
    rix0rrr and github-actions authored Mar 3, 2025
    Copy the full SHA
    806d851 View commit details
  7. refactor: move util into shared library (#183)

    Mostly moving and import updates.
    Renamed a couple of functions.
    Added some more AI generated test cases for utils.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    mrgrain authored Mar 3, 2025
    Copy the full SHA
    a48d3db View commit details
  8. feat(bootstrap): Add ECR resource policy for emr-serverless containers (

    #112)
    
    This PR modifies the default bootstrap template to support EMR
    Serverless containers.
    
    Without this policy, containers created using the `DockerImageAsset`
    construct cannot be used with EMR Serverless applications.
    
    There is precedence for this pattern to support Lambda function
    containers, so I don't think this should be too controversial of a
    change.
    
    Relevant documentation on using custom images in EMR Serverless:
    -
    https://docs.aws.amazon.com/emr/latest/EMR-Serverless-UserGuide/application-custom-image.html
    
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    graydenshand authored Mar 3, 2025
    Copy the full SHA
    478113d View commit details
  9. feat: assets can have a display name (#175)

    Add a new field to the asset schema: `displayName`.
    
    If supplied, it will be used instead of the asset ID for display
    purposes in `cdk-assets` and in the CLI.
    
    This adds support for display names to the contract and to the CLI. A
    future PR in `aws-cdk-lib` will make it possible to configure display
    names on Asset objects, and add the same support to CDK Pipelines.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    
    ---------
    
    Signed-off-by: github-actions <github-actions@github.com>
    Co-authored-by: github-actions <github-actions@github.com>
    rix0rrr and github-actions authored Mar 3, 2025
    Copy the full SHA
    7c65899 View commit details
  10. feat(toolkit-lib): bootstrap action (#63)

    Fixes aws/aws-cdk#33180. Typed return will be
    included in a follow-up PR.
    
    Description:  
    
    Bootstrap Action for the CDK Toolkit.
    
    Testing:
    - Unit test coverage for:
      - Bootstrap stack creation
      - No-op (no stack changes)
      - Generic bootstrap error
      - Permissions error during bootstrap
    - Bootstrapped an environment in a test account using this code
    
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    
    ---------
    
    Signed-off-by: github-actions <github-actions@github.com>
    Co-authored-by: github-actions <github-actions@github.com>
    Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
    3 people authored Mar 3, 2025
    Copy the full SHA
    faa2de0 View commit details

Commits on Mar 4, 2025

  1. fix: don't show built-in Node lifetime warnings (#186)

    We have moved to using Notices to display Node support warnings, so we
    should disable the built-in warnings provided by `@jsii/check-node`.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    
    ---------
    
    Signed-off-by: github-actions <github-actions@github.com>
    Co-authored-by: github-actions <github-actions@github.com>
    rix0rrr and github-actions authored Mar 4, 2025
    Copy the full SHA
    3710b78 View commit details
  2. fix(toolkit-lib): ToolkitError is not exported (#187)

    Fixes `'@aws-cdk/toolkit-lib' has no exported member named
    'ToolkitError'`
    
    Because we are now moving parts of the public API into a shared package,
    we also need to export the respective types.
    During the regular build, type declarations are not bundled. So we need
    to take care of it afterwards.
    This is not ideal, but required. Thankfully the temporary package is a,
    well, temporary construct and we are actively working to get rid of it
    (first by adding new stuff, then by moving everything to `toolkit-lib`).
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    mrgrain authored Mar 4, 2025
    Copy the full SHA
    04cdb98 View commit details
  3. chore: use the same typescript version everywhere (#190)

    I was getting warnings from eslint plugins about an unsupported
    typescript version (5.8). Then I noticed that the monorepo root is the
    only package that doesn't use the "global" version.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    mrgrain authored Mar 4, 2025
    Copy the full SHA
    01acccf View commit details

Commits on Mar 5, 2025

  1. chore(toolkit-lib): fix code registry is disconnected from usage (#191)

    Previously the declared `level` and payload interfaces were only loosely
    coupled to actual messages being created. This caused a number of issues
    with incorrectly documented levels and payload interfaces.
    
    Instead of the previous approach, the code registry is now providing a
    strongly typed "message builder" function specific to every registered
    code. This function uses generics, so it can correctly ensure at build
    time that payloads are as expected.
    
    This is the first PR of this series to keep the diff small. Next steps
    will be to make the code registry available to the CLI package and to
    remove the old helpers for creating messages.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    mrgrain authored Mar 5, 2025
    Copy the full SHA
    2f0caf4 View commit details
  2. chore: publish cdk-assets as latest (#189)

    We are currently running `cdk-assets` v3 as `latest`, and it is working
    fine. Make this the official disttag for this version.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    rix0rrr authored Mar 5, 2025
    Copy the full SHA
    c46717c View commit details
  3. fix: handle cross-device link error in build-standalone-zip task (#195)

    ## Description
    When building the AWS CDK CLI, a .zip file is created in a temporary
    directory and moved afterward.
    
    In certain environments, "cross-device link" fails. When the user's
    workspace is in a mounted volume, moving of a file fails during the
    build step because `fs.rename()` only works when the source and
    destination are in the same filesystem.
    
    <img width="669" alt="Screenshot 2025-03-05 at 13 08 20"
    src="https://github.com/user-attachments/assets/6f108a34-f358-4f39-ac2e-6f6dbb147e22"
    />
    
    ## Solution
    Copy the source file to the destination and delete the source file. This
    achieves the same result, but prevents us from running into limitations
    across filesystems.
    
    ## Testing
    Ran `yarn build` successfully and all tests pass.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    iankhou authored Mar 5, 2025
    Copy the full SHA
    f59332f View commit details
  4. chore(cli): remove unused destroy options (#196)

    These are not used downstream, so let's remove them for clarity.
    
    Note that low-level force destroy is a thing in CFN and we _might_
    reintroduce this later. It's basically about abandoning failed
    resources. But we currently don't support it, so let's not bother.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    mrgrain authored Mar 5, 2025
    Copy the full SHA
    035c527 View commit details
  5. docs(toolkit-lib): add CODE_REGISTRY directly to doc site (#199)

    Looks like this on the doc site:
    
    <img width="1418" alt="Screenshot 2025-03-05 at 5 03 51 PM"
    src="https://github.com/user-attachments/assets/dd938d26-d66f-45fd-9474-5609c62f9c08"
    />
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    
    ---------
    
    Signed-off-by: github-actions <github-actions@github.com>
    Co-authored-by: github-actions <github-actions@github.com>
    kaizencc and github-actions authored Mar 5, 2025
    Copy the full SHA
    e145d55 View commit details

Commits on Mar 6, 2025

  1. chore: update parameters in issue-label-assign (#198)

    I am trying to coerce the workflow to label `aws-cdk` more than
    `@aws-cdk/cli-lib-alpha` since it's far more likely that any issue that
    comes in is for the cdk cli.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    kaizencc authored Mar 6, 2025
    Copy the full SHA
    b242c23 View commit details
Loading