Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aws/aws-cdk-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cdk@v2.1000.3
Choose a base ref
...
head repository: aws/aws-cdk-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cdk@v2.1001.0
Choose a head ref
  • 9 commits
  • 174 files changed
  • 4 contributors

Commits on Feb 25, 2025

  1. chore(toolkit-lib): fix docs publishing workflow (#126)

    Erroneously used the wrong artifact name before.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    mrgrain authored Feb 25, 2025

    Unverified

    The signing certificate or its chain could not be verified.
    Copy the full SHA
    0dcb15a View commit details
  2. docs(toolkit-lib): fix some examples (#127)

    Fixes some incorrect examples and makes formatting consistent for
    others.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    mrgrain authored Feb 25, 2025
    Copy the full SHA
    46d28cb View commit details
  3. chore: remove duplicate cli resource files (#129)

    CLI derivative packages should never check-in their own version of CLI
    resource files (bootstrap template, init templates, etc.). Instead they
    are expected to copy any required files over at build time.
    
    This PR removes the checked-in version of `init-templates` and bootstrap
    template from `cli-lib-alpha`.
    It also adds respective gitignore and npmignore rules.
    
    Note that neither `cli-lib-alpha` nor `toolkit-lib` currently support
    the init command and therefore don't need the templates just yet.
    
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    mrgrain authored Feb 25, 2025
    Copy the full SHA
    a8b73da View commit details
  4. docs(toolkit-lib): include VERSION file (#131)

    The docs build requires this file to contain the current version number.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    mrgrain authored Feb 25, 2025
    Copy the full SHA
    2a57bc9 View commit details
  5. feat(cli): can match notices against Node version (#128)

    This allows publishing notices that match against the version of Node
    we're executing on.
    
    Implemented by generalizing the code that matches against CLI version
    and bootstrap versions: it can now match against arbitrary named
    components.
    
    Also implement more complex matching rules: currently we match the
    pattern if one of them matches:
    
    ```ts
    // Matches if one of A, B or C matches
    components: [A, B, C]
    ```
    
    Instead, generalize to Disjunctive Normal Form and treat the current
    case as a special case of DNF where every conjunction has one element:
    
    ```ts
    // The above gets interpreted as
    components: [[A], [B], [C]]
    
    // More complex rules: A and B together, or C
    components: [[A, B], [C]]
    ```
    
    This way we can write rules to say that "component X on Node version Y"
    should get a notice.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    rix0rrr authored Feb 25, 2025
    Copy the full SHA
    757ae69 View commit details
  6. docs(toolkit-lib): CODE_REGISTRY.md tracks valid codes and their docu…

    …mentation (#44)
    
    closes aws/aws-cdk#33434
    
    generates `CODE_REGISTRY.md` using information gathered in `codes.ts`.
    this pr:
    
    - updates `codes.ts` to have additional information stored
    - introduces a script that generates a markdown table from the `CODES`
    object
    - updates projen to build `CODE_REGISTRY.md` as a post-build step
    
    ---
    
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    
    ---------
    
    Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
    kaizencc and mrgrain authored Feb 25, 2025
    Copy the full SHA
    fdf54d0 View commit details

Commits on Feb 26, 2025

  1. chore: github issue templates (#153)

    Grrr, no projen support: projen/projen#3567.
    I'm lazy so I just copied and pasted a few from the aws-cdk repo. This
    is somewhat necessary because it adds the `needs-triage` label
    automatically, that my other PR will need:
    #118
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    kaizencc authored Feb 26, 2025
    Copy the full SHA
    3b7115d View commit details
  2. chore: fix issue templates not working (#156)

    They were in the wrong path. See
    https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    mrgrain authored Feb 26, 2025
    Copy the full SHA
    88e2bdf View commit details
  3. feat(cli): build your own fromLookup() imports with the new context…

    … provider for CloudControl API (#138)
    
    A generic Context Provider for CloudControl API. See
    aws/aws-cdk#33258 for an example how to
    implement a `fromLookup()` method using the new context provider.
    
    (Extracted from aws/aws-cdk#33258)
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    
    ---------
    
    Signed-off-by: github-actions <github-actions@github.com>
    Co-authored-by: github-actions <github-actions@github.com>
    Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
    3 people authored Feb 26, 2025
    Copy the full SHA
    130445d View commit details
Loading