Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregation CFN template for Data Exports #787

Merged
merged 23 commits into from
Jun 11, 2024

Conversation

AWS-ZachErdman
Copy link
Contributor

This commit adds a new cloudformation template to support CUR 2.0 in Data Exports with the same functionality as cur-aggregation.yaml

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This commit adds a new cloudformation template to support CUR 2.0 in Data Exports with the same functionality as `cur-aggregation.yaml`
Copy link
Contributor

@yprikhodko yprikhodko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I've added few comments inline. Also I see that PermissionsBoundary parameter and policy property excluded compare to current version. Is this intentional? https://github.com/aws-samples/aws-cudos-framework-deployment/blob/02aec4cdda9e2e86e2b67b0e0ae315384a49be2a/cfn-templates/cid-cfn.yml#L211

@AWS-ZachErdman
Copy link
Contributor Author

Great work! I've added few comments inline. Also I see that PermissionsBoundary parameter and policy property excluded compare to current version. Is this intentional?

https://github.com/aws-samples/aws-cudos-framework-deployment/blob/02aec4cdda9e2e86e2b67b0e0ae315384a49be2a/cfn-templates/cid-cfn.yml#L211

@yprikhodko I had it in the version you shared with me, but it wasn't in the version that was present on Well Architected Labs website. It also kept causing errors for me when I tried to upload the template if I didn't specify anything in that field so I ended up just removing it.

We can add it back in if you'd like and know how to make it not error.

Screenshot 2024-04-14 at 7 37 25 PM

Made updates suggested by Yuriy and Iakov
@AWS-ZachErdman
Copy link
Contributor Author

AWS-ZachErdman commented Apr 19, 2024

@yprikhodko and @iakov-aws have you seen this error before? I'm getting it when trying to run the CFN template outside of us-east-1

All other resources besides SourceS3 seem to be deploying correctly.

image

@iakov-aws
Copy link
Contributor

This might happen if you delete s3 in one region and then try to recreate in another one too soon with the same name. You can try changing prefix or wait a bit more.

@iakov-aws iakov-aws merged commit 20527e5 into aws-solutions-library-samples:main Jun 11, 2024
16 of 18 checks passed
@iakov-aws
Copy link
Contributor

Great job @AWS-ZachErdman and @petrokashlikov ! Awesome contribution that will help many customers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants