-
Notifications
You must be signed in to change notification settings - Fork 186
add conditions for cur s3 policies #825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@sean-nixon can you have a look at TF part? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left some inline comments, but at a higher level, all of these changes should be made to the cur-setup-destination module, not the cur-setup-source module.
Great feedback. Please can you approve the new version? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I run bats tests locally and they failed. You're using current
in your data source references but the original code uses this
. Added inline code suggestions to move everything to this
to be consistent.
@iakov-aws Let me know if I can do anything else to support this |
Co-authored-by: Sean Nixon <sean-nixon@users.noreply.github.com>
Co-authored-by: Sean Nixon <sean-nixon@users.noreply.github.com>
Co-authored-by: Sean Nixon <sean-nixon@users.noreply.github.com>
Co-authored-by: Sean Nixon <sean-nixon@users.noreply.github.com>
Co-authored-by: Sean Nixon <sean-nixon@users.noreply.github.com>
Co-authored-by: Sean Nixon <sean-nixon@users.noreply.github.com>
…ne uses wildcard with Like operator
…erator (#879)
Hello, |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.