chore(deps): upgrade axios to 1.6.0 #12489
Merged
+127
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trigger e2e
AllanZhengYP
previously approved these changes
Nov 1, 2023
AllanZhengYP
reviewed
Nov 1, 2023
| @@ -48,7 +48,8 @@ | |||
| }, | |||
| "homepage": "https://aws-amplify.github.io/", | |||
| "devDependencies": { | |||
| "@types/zen-observable": "^0.8.0" | |||
| "@types/zen-observable": "^0.8.0", | |||
| "typescript": "5.0.2" | |||
There was a problem hiding this comment.
Can you do a quick check with the v6 tsc-compatibility-test to make sure we don't break interface consumption in older TSC?
david-mcafee
previously requested changes
Nov 2, 2023
| @@ -9,7 +9,7 @@ on: | |||
| push: | |||
| branches: | |||
| # Change this to your branch name where "example-preid" corresponds to the preid you want your changes released on | |||
| - feat/example-preid-branch/main | |||
| - fix/v5-upgrade-axios | |||
jimblanc
reviewed
Nov 2, 2023
packages/api-graphql/package.json
Outdated
Comment on lines
23
to
25
| "build:esm": "rimraf lib-esm && tsc -m esnext --outDir lib-esm", | ||
| "build:cjs:watch": "rimraf lib && tsc -m commonjs --outDir lib --watch", | ||
| "build:esm:watch": "rimraf lib-esm && tsc -m esnext --outDir lib-esm --watch", |
packages/api-rest/package.json
Outdated
Comment on lines
23
to
25
| "build:esm": "rimraf lib-esm && tsc -m esnext --outDir lib-esm", | ||
| "build:cjs:watch": "rimraf lib && tsc -m commonjs --outDir lib --watch", | ||
| "build:esm:watch": "rimraf lib-esm && tsc -m esnext --outDir lib-esm --watch", |
elorzafe
force-pushed
the
fix/v5-upgrade-axios
branch
from
05638d0 to
0254b4f
Compare
AllanZhengYP
previously approved these changes
Nov 3, 2023
stocaaro
previously approved these changes
Nov 3, 2023
AllanZhengYP
changed the title
AllanZhengYP
previously approved these changes
Nov 6, 2023
elorzafe
commented
Nov 6, 2023
jimblanc
approved these changes
Nov 6, 2023
AllanZhengYP
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
api-rest5.0.2and build scripts onapi-rest,api-graphqlandapipackages similar tocoreIssue #, if available
Axios version needs to be upgrade
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.