Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Recommending using OIDC #871

Merged
merged 4 commits into from
Sep 29, 2023
Merged

feat: Recommending using OIDC #871

merged 4 commits into from
Sep 29, 2023

Conversation

jplock
Copy link
Contributor

@jplock jplock commented Sep 29, 2023

Issue #, if available: N/A

Description of changes: We should recommend that customers use OpenID Connect to authenticate instead of long-term credentials


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jplock jplock changed the title Recommending using OIDC feat: Recommending using OIDC Sep 29, 2023
Copy link
Contributor

@peterwoodworth peterwoodworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jplock, this is a good warning to throw 🙂

I think this will end up throwing a warning when there are no permanent credentials being used - e.g. if you are role chaining. I think if you hide this warning behind a check for the absence of AWS_SESSION_TOKEN then we will only throw this when we want to.

Additionally, we should have this warning in our unit test coverage. At least one unit test that role-chains should explicitly not throw this warning, and at least one unit test should explicitly throw this warning with user credentials

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants