Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3 does not work with instance roles #817

Closed
iNoahNothing opened this issue Aug 30, 2023 · 1 comment · Fixed by #818
Closed

v3 does not work with instance roles #817

iNoahNothing opened this issue Aug 30, 2023 · 1 comment · Fixed by #818
Labels
bug Something isn't working effort/small This issue will take less than a day of effort to fix p1

Comments

@iNoahNothing
Copy link

iNoahNothing commented Aug 30, 2023 •
edited

Describe the bug

v3 does not automatically assume role assigned to internal runner as described in the README.

Expected Behavior

The role assigned to the runner to be assumed

Current Behavior

uses: aws-actions/configure-aws-credentials@v3
with:
  aws-region: us-east-1

now returns Error: Could not determine how to assume credentials. Please check your inputs and try again.

Reproduction Steps

Use a self-hosted runner and use configure-aws-credentials just specifying the region.

Possible Solution

No response

Additional Information/Context

We have OIDC setup so github actions can assume other roles. This works well when role-to-assume is set
@iNoahNothing iNoahNothing added bug Something isn't working needs-triage This issue still needs to be triaged labels Aug 30, 2023
@peterwoodworth peterwoodworth changed the title short issue description v3 does not work with instane roles Aug 30, 2023
@peterwoodworth peterwoodworth added p1 effort/small This issue will take less than a day of effort to fix and removed needs-triage This issue still needs to be triaged labels Aug 30, 2023
@peterwoodworth peterwoodworth mentioned this issue Aug 30, 2023
Merged
1 task
@peterwoodworth peterwoodworth changed the title v3 does not work with instane roles v3 does not work with instance roles Aug 30, 2023
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working effort/small This issue will take less than a day of effort to fix p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: validation logic throwing unwanted errors aws-actions/configure-aws-credentials
2 participants
@iNoahNothing @peterwoodworth