Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 breaks by somehow assuming the use of OIDC #792

Closed
Neurrone opened this issue Aug 24, 2023 · 5 comments · Fixed by #796
Closed

V3 breaks by somehow assuming the use of OIDC #792

Neurrone opened this issue Aug 24, 2023 · 5 comments · Fixed by #796
Labels
bug Something isn't working p1 response-requested Waiting on additional info and feedback. Will move to 'closing-soon' in 5 days.

Comments

@Neurrone
Copy link

Describe the bug

The action fails and somehow assumes the use of OIDC, even though it wasn't being used / configured.

Expected Behavior

No breakage when updating to V3

Current Behavior

Action fails with the following error:

It looks like you might be trying to authenticate with OIDC. Did you mean to set the `id-token` permission?
Error: Could not determine how to assume credentials. Please check your inputs and try again.

Reproduction Steps

    - name: Assume deployment role
      uses: aws-actions/configure-aws-credentials@v3
      with:
        aws-region: ${{ env.AWS_REGION }}
        role-to-assume: ${{ env.DEPLOYER_ROLE_ARN }}
        role-skip-session-tagging: true
        role-duration-seconds: 1800
        role-external-id: ${{ env._EXTERNAL_ID }}

Possible Solution

No response

Additional Information/Context

No response

@Neurrone Neurrone added bug Something isn't working needs-triage This issue still needs to be triaged labels Aug 24, 2023
@peterwoodworth
Copy link
Contributor

peterwoodworth commented Aug 24, 2023

If you aren't intending to use OIDC then what are you attempting to use? The set of inputs you have here indicate you want to use OIDC https://github.com/aws-actions/configure-aws-credentials#using-this-action, this hasn't changed from v2, are you trying to use credentials that exist in your runner already?

@peterwoodworth peterwoodworth added response-requested Waiting on additional info and feedback. Will move to 'closing-soon' in 5 days. and removed needs-triage This issue still needs to be triaged labels Aug 24, 2023
@Neurrone
Copy link
Author

I'm Assuming Role using existing credentials.

It worked for me in v2, so I was surprised when the v3 update broke this. Was the usage of the workflow for my use case using the wrong parameters?

@peterwoodworth
Copy link
Contributor

The way v2 used existing credentials was inconsistent depending on certain ways the workflow was setup - I honestly didn't know the setup you have was valid in v2 as it was undocumented, and since I've taken over I don't think I've seen anyone have a setup like this that worked. So, I didn't consider this case for v3 when it was necessary to rewrite the logic. I'd like v3 to be fully backwards compatible, so I'll see if I can smoothly fit this use case back in tomorrow. Until then, you could continue using v2, or you can set the role-chaining prop to true to indicate you want to use the variables already present in your runner

@aballman
Copy link

aballman commented Aug 24, 2023

I'm having the same issue. My scenario is self-hosted runners in EKS with IRSA. I have no need for the Github OIDC endpoint. My configuration worked great in v2 but now breaks in v3.

      - name: Configure AWS Credentials
        uses: aws-actions/configure-aws-credentials@v3
        with:
          aws-region: 
          role-to-assume: 
          role-duration-seconds: 
          role-session-name: 

It looks like you might be trying to authenticate with OIDC. Did you mean to set the id-token permission?
Error: Could not determine how to assume credentials. Please check your inputs and try again.

edit: role-chaining prop fixed me up

@github-actions
Copy link

** Note **
Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p1 response-requested Waiting on additional info and feedback. Will move to 'closing-soon' in 5 days.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants