Skip to content

fix: Link to events v2 url #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 29, 2024
Merged

fix: Link to events v2 url #588

merged 5 commits into from
Jul 29, 2024

Conversation

Fran-Rg
Copy link
Contributor

@Fran-Rg Fran-Rg commented Jul 26, 2024

Issue #, if available:

Description of changes:
The url to check the events is using the v1, the v2 has been released since around Jan 2023 and isn't backward compatible. Just a Quality of Life thing

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Fran-Rg Fran-Rg changed the title Link to events v2 url fix: Link to events v2 url Jul 27, 2024
Fran-Rg and others added 3 commits July 27, 2024 01:23
@Fran-Rg Fran-Rg closed this Jul 29, 2024
@Fran-Rg Fran-Rg reopened this Jul 29, 2024
@Fran-Rg
Copy link
Contributor Author

Fran-Rg commented Jul 29, 2024

This time with npm test locally tested

PS: are you sure you want: "Send Notifications to Slack" to require approval? https://github.com/aws-actions/amazon-ecs-deploy-task-definition/actions/runs/10143607123

@Fran-Rg
Copy link
Contributor Author

Fran-Rg commented Jul 29, 2024

And fixed package test

@omkhegde omkhegde merged commit 1a69dae into aws-actions:master Jul 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants