Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade target frameworks and packages #162

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

Joy-less
Copy link
Contributor

@Joy-less Joy-less commented Jan 3, 2025

This pull request:

  • Adds netstandard2.1, .net8.0, net9.0 targets, which may improve performance at a small cost to the size of the nupkg.
  • Upgrades NuGet packages to the latest versions.

I also noticed this library is using NUnit, which is a little old and verbose. Would you be interested in migrating to xUnit (or TUnit), or are you okay sticking with NUnit?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@awaescher
Copy link
Owner

Awesome. Would you mind moving common properties like <LangVersion> and <Nullable> for all projects into one single Directory.Build.props maybe?
I don't mind NUnit, it works great with NCrunch, for example. I guess xUnit would do too, but I don't have a strong opinion here.

@Joy-less
Copy link
Contributor Author

Joy-less commented Jan 3, 2025

@awaescher Added Directory.Build.targets for LangVersion, Nullable and ImplicitUsings.
Also did some minor cleanups.

@awaescher
Copy link
Owner

Awesome. The build fails, I guess you need to make sure .NET 9 is available, too.

# workflows/ci.yml
    - name: Setup .NET
      uses: actions/setup-dotnet@v2
      with:
        dotnet-version: | 
          6.0.x
          8.0.x

@Joy-less
Copy link
Contributor Author

Joy-less commented Jan 7, 2025

@awaescher I removed .NET 6.0 (because it's out of support) and added .NET 9.0.

@awaescher awaescher merged commit a7daa3f into awaescher:main Jan 8, 2025
1 check passed
@awaescher
Copy link
Owner

Thanks @Joy-less for helping out 🙏

JerrettDavis added a commit to JerrettDavis/OllamaSharp that referenced this pull request Jan 9, 2025
JerrettDavis added a commit to JerrettDavis/OllamaSharp that referenced this pull request Jan 9, 2025
awaescher added a commit that referenced this pull request Jan 9, 2025
Corrected documentation build after #162 added .NET 9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants