IT-522 - Add support for path #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added internal issue id to pull request title |
|
For me these changes are good and I would merge them. But first I will update the project version and Readme for our internal workflow conditions. @julian-eggers I think we need a contribution guide in the Readme? |
|
Merging is now possible, contribution instruction guide are on our list now! |
hnrkdmsk
approved these changes
Dec 30, 2021
julian-eggers
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation states that paths are supported but the
getProjectVersionfunction requires thefileToCheckbe just a file name.Updated to get the
fileNamefrom the full path to the file.