feat: resolve bun/deno compat issues #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
2 tasks
adamjmcgrath
approved these changes
Oct 5, 2023
Closed
adamjmcgrath
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since compatibility modes are becoming more and more popular it is inevitable that jwks-rsa is used in bun/deno sooner or later (actually, already might be). Because of how these runtimes fail to recognize CJS and treat its require calls to use the dependency's require package.json target we can't depend on using a node-runtime ignored algorithm argument and have to provide an actual value.
References
Testing
This only stands to improve non-officially supported runtimes for this module, it does not affect how the module behaves under node.js runtime