From ce406af84aedf868b1e7618e5113d1899a914f07 Mon Sep 17 00:00:00 2001 From: Adam Mcgrath Date: Wed, 14 Jun 2023 17:10:17 +0100 Subject: [PATCH] This was a wrong test thrown off by https://github.com/salesforce/tough-cookie/pull/240 --- tests/auth0-session/transient-store.test.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/auth0-session/transient-store.test.ts b/tests/auth0-session/transient-store.test.ts index 3c4eb338f..426371aeb 100644 --- a/tests/auth0-session/transient-store.test.ts +++ b/tests/auth0-session/transient-store.test.ts @@ -83,7 +83,7 @@ describe('TransientStore', () => { expect(cookie?.secure).toBeFalsy(); }); - it('should set SameSite=None, Secure=False for fallback cookie by default for http', async () => { + it('should not set SameSite and set Secure=False for fallback cookie by default for http', async () => { const baseURL: string = await setup( defaultConfig, (req: NodeRequest, res: NodeResponse) => { @@ -96,9 +96,8 @@ describe('TransientStore', () => { const { value } = await get(baseURL, '/', { cookieJar }); const fallbackCookie = getCookie('_test_key', cookieJar, baseURL); expect(value).toEqual(expect.any(String)); - // TODO: figure out why this is sameSite 'none' (and why it's passing in main) expect(fallbackCookie).toMatchObject({ - sameSite: 'none', + sameSite: undefined, secure: false, httpOnly: true });