Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py test is bad practice #500

Closed
jamesmyatt opened this issue Jul 4, 2019 · 7 comments
Closed

setup.py test is bad practice #500

jamesmyatt opened this issue Jul 4, 2019 · 7 comments

Comments

@jamesmyatt
Copy link

setup.py test is deprecated and will be removed one day: pypa/setuptools#1684
pytest-runner is no longer recommended: pytest-dev/pytest-runner#50

The project should be updated to avoid these "smells".

@graingert
Copy link

graingert commented Jul 5, 2019

It might also be worth pyproject.toml PEP517/PEP518 support too, eg scrap setup.py altogether and use something like flit

@pganssle
Copy link

pyproject.toml is orthogonal to setup.py. This project should definitely add a pyproject.toml, but I'm not sure I'd recommend switching it over to a different build backend.

ChadBailey added a commit to ChadBailey/cookiecutter-pypackage that referenced this issue Nov 24, 2019
ChadBailey added a commit to ChadBailey/cookiecutter-pypackage that referenced this issue Nov 24, 2019
@ChadBailey
Copy link
Contributor

Please see my PR #544 which should remove all references to setup.py test

ChadBailey added a commit to ChadBailey/cookiecutter-pypackage that referenced this issue Nov 24, 2019
@trybik
Copy link

trybik commented Feb 5, 2020

Please see my PR #544 which should remove all references to setup.py test

In accordance with deprecation notice of pytest-runner:

It is recommended that you:

  • Remove ‘pytest-runner’ from your ‘setup_requires’, preferably removing the setup_requires option.
  • Remove ‘pytest’ and any other testing requirements from ‘tests_require’, preferably removing the setup_requires option.`

Both are still in {{cookiecutter.project_slug}}/setup.py and not in PR #544.

@ChadBailey
Copy link
Contributor

Good catch, thanks for pointing out this omission. I'll update if I find the time but feel free to do so yourself

@phith0n
Copy link

phith0n commented Feb 21, 2021

I ran into the same problem.

@pydanny
Copy link
Collaborator

pydanny commented Apr 6, 2024

Thanks everyone for their commentary. We're ihave removed python setup.py test. 😄

@pydanny pydanny closed this as completed Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants
@pydanny @trybik @graingert @jamesmyatt @pganssle @phith0n @ChadBailey and others