Skip to content

Fix Python 3.12 build #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Fix Python 3.12 build #1263

merged 1 commit into from
Oct 19, 2023

Conversation

offa
Copy link
Contributor

@offa offa commented Oct 18, 2023

Fixes the Python 3.12 CI build (see #1262).

Remarks:

The flake8 version used in the CI build is quite old, but an upgrade is blocked by flake8-no-fstring (needs flake8<4). An update to the latest version isn't possible as flake8 6.x does no longer support Python 3.6 and 3.7.

Are importlib-metadata downgrade and flake8-no-fstring still necessary? The later should be fixed by recent flake8 versions.

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b85ac5f) 34.42% compared to head (dc754fe) 34.42%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1263   +/-   ##
=======================================
  Coverage   34.42%   34.42%           
=======================================
  Files          44       44           
  Lines        8116     8116           
  Branches     1123     1123           
=======================================
  Hits         2794     2794           
  Misses       5208     5208           
  Partials      114      114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gonchik gonchik merged commit 27a84d2 into atlassian-api:master Oct 19, 2023
@offa offa deleted the fix_python312 branch October 20, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants