Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove on.push hook in Project Analysis workflow as CodeQL no longer requires it to be paired with on.pull_request #60

Closed
26 tasks done
atc0005 opened this issue May 25, 2023 · 1 comment
Assignees

Comments

@atc0005
Copy link
Owner

atc0005 commented May 25, 2023

Overview

From the v2.3.4 codeql-action changelog:

Remove the requirement for on.push and on.pull_request to trigger on the same branches. github/codeql-action#1675

TODO

  • atc0005/bounce
  • atc0005/brick
  • atc0005/bridge
  • atc0005/check-cert
  • atc0005/check-illiad
  • atc0005/check-mail
  • atc0005/check-ntpt
  • atc0005/check-path
  • atc0005/check-process
  • atc0005/check-restart
  • atc0005/check-statuspage
  • atc0005/check-vmware
  • atc0005/check-whois
  • atc0005/dnsc
  • atc0005/elbow
  • atc0005/go-ci
  • atc0005/go-ezproxy
  • atc0005/go-lockss
  • atc0005/mysql2sqlite
  • atc0005/go-nagios
  • atc0005/go-teams-notify
  • atc0005/nagios-debug
  • atc0005/query-meta
  • atc0005/safelinks
  • atc0005/send2teams
  • atc0005/tsm-pass

References

@atc0005 atc0005 self-assigned this May 25, 2023
atc0005 added a commit to atc0005/check-vmware that referenced this issue Jun 8, 2023
This hook was previously needed for proper operation of the
`Vulnerability / CodeQL` job so that it could compare before/after
changes against the base branch.

This requirement was removed as part of recent work in the
github/codeql-action project.

I'm keeping the event type check for jobs already using it for the
time being.

refs atc0005/todo#60
atc0005 added a commit to atc0005/bounce that referenced this issue Jun 8, 2023
This hook was previously needed for proper operation of the
`Vulnerability / CodeQL` job so that it could compare before/after
changes against the base branch.

This requirement was removed as part of recent work in the
github/codeql-action project.

I'm keeping the event type check for jobs already using it for the
time being.

refs atc0005/todo#60
atc0005 added a commit to atc0005/brick that referenced this issue Jun 8, 2023
This hook was previously needed for proper operation of the
`Vulnerability / CodeQL` job so that it could compare before/after
changes against the base branch.

This requirement was removed as part of recent work in the
github/codeql-action project.

I'm keeping the event type check for jobs already using it for the
time being.

refs atc0005/todo#60
atc0005 added a commit to atc0005/go-lockss that referenced this issue Jun 9, 2023
This hook was previously needed for proper operation of the
`Vulnerability / CodeQL` job so that it could compare before/after
changes against the base branch.

This requirement was removed as part of recent work in the
github/codeql-action project.

I'm keeping the event type check for jobs already using it for the
time being.

refs atc0005/todo#60
atc0005 added a commit to atc0005/bridge that referenced this issue Jun 9, 2023
This hook was previously needed for proper operation of the
`Vulnerability / CodeQL` job so that it could compare before/after
changes against the base branch.

This requirement was removed as part of recent work in the
github/codeql-action project.

I'm keeping the event type check for jobs already using it for the
time being.

refs atc0005/todo#60
atc0005 added a commit to atc0005/check-cert that referenced this issue Jun 9, 2023
This hook was previously needed for proper operation of the
`Vulnerability / CodeQL` job so that it could compare before/after
changes against the base branch.

This requirement was removed as part of recent work in the
github/codeql-action project.

I'm keeping the event type check for jobs already using it for the
time being.

refs atc0005/todo#60
atc0005 added a commit to atc0005/check-illiad that referenced this issue Jun 9, 2023
This hook was previously needed for proper operation of the
`Vulnerability / CodeQL` job so that it could compare before/after
changes against the base branch.

This requirement was removed as part of recent work in the
github/codeql-action project.

I'm keeping the event type check for jobs already using it for the
time being.

refs atc0005/todo#60
atc0005 added a commit to atc0005/check-mail that referenced this issue Jun 9, 2023
This hook was previously needed for proper operation of the
`Vulnerability / CodeQL` job so that it could compare before/after
changes against the base branch.

This requirement was removed as part of recent work in the
github/codeql-action project.

I'm keeping the event type check for jobs already using it for the
time being.

refs atc0005/todo#60
atc0005 added a commit to atc0005/check-ntpt that referenced this issue Jun 9, 2023
This hook was previously needed for proper operation of the
`Vulnerability / CodeQL` job so that it could compare before/after
changes against the base branch.

This requirement was removed as part of recent work in the
github/codeql-action project.

I'm keeping the event type check for jobs already using it for the
time being.

refs atc0005/todo#60
atc0005 added a commit to atc0005/check-path that referenced this issue Jun 9, 2023
This hook was previously needed for proper operation of the
`Vulnerability / CodeQL` job so that it could compare before/after
changes against the base branch.

This requirement was removed as part of recent work in the
github/codeql-action project.

I'm keeping the event type check for jobs already using it for the
time being.

refs atc0005/todo#60
atc0005 added a commit to atc0005/check-process that referenced this issue Jun 9, 2023
This hook was previously needed for proper operation of the
`Vulnerability / CodeQL` job so that it could compare before/after
changes against the base branch.

This requirement was removed as part of recent work in the
github/codeql-action project.

I'm keeping the event type check for jobs already using it for the
time being.

refs atc0005/todo#60
atc0005 added a commit to atc0005/check-restart that referenced this issue Jun 9, 2023
This hook was previously needed for proper operation of the
`Vulnerability / CodeQL` job so that it could compare before/after
changes against the base branch.

This requirement was removed as part of recent work in the
github/codeql-action project.

I'm keeping the event type check for jobs already using it for the
time being.

refs atc0005/todo#60
atc0005 added a commit to atc0005/check-statuspage that referenced this issue Jun 9, 2023
This hook was previously needed for proper operation of the
`Vulnerability / CodeQL` job so that it could compare before/after
changes against the base branch.

This requirement was removed as part of recent work in the
github/codeql-action project.

I'm keeping the event type check for jobs already using it for the
time being.

refs atc0005/todo#60
atc0005 added a commit to atc0005/check-whois that referenced this issue Jun 9, 2023
This hook was previously needed for proper operation of the
`Vulnerability / CodeQL` job so that it could compare before/after
changes against the base branch.

This requirement was removed as part of recent work in the
github/codeql-action project.

I'm keeping the event type check for jobs already using it for the
time being.

refs atc0005/todo#60
atc0005 added a commit to atc0005/dnsc that referenced this issue Jun 9, 2023
This hook was previously needed for proper operation of the
`Vulnerability / CodeQL` job so that it could compare before/after
changes against the base branch.

This requirement was removed as part of recent work in the
github/codeql-action project.

I'm keeping the event type check for jobs already using it for the
time being.

refs atc0005/todo#60
atc0005 added a commit to atc0005/elbow that referenced this issue Jun 9, 2023
This hook was previously needed for proper operation of the
`Vulnerability / CodeQL` job so that it could compare before/after
changes against the base branch.

This requirement was removed as part of recent work in the
github/codeql-action project.

I'm keeping the event type check for jobs already using it for the
time being.

refs atc0005/todo#60
atc0005 added a commit to atc0005/tsm-pass that referenced this issue Jun 9, 2023
This hook was previously needed for proper operation of the
`Vulnerability / CodeQL` job so that it could compare before/after
changes against the base branch.

This requirement was removed as part of recent work in the
github/codeql-action project.

I'm keeping the event type check for jobs already using it for the
time being.

refs atc0005/todo#60
atc0005 added a commit to atc0005/send2teams that referenced this issue Jun 9, 2023
This hook was previously needed for proper operation of the
`Vulnerability / CodeQL` job so that it could compare before/after
changes against the base branch.

This requirement was removed as part of recent work in the
github/codeql-action project.

I'm keeping the event type check for jobs already using it for the
time being.

refs atc0005/todo#60
atc0005 added a commit to atc0005/safelinks that referenced this issue Jun 9, 2023
This hook was previously needed for proper operation of the
`Vulnerability / CodeQL` job so that it could compare before/after
changes against the base branch.

This requirement was removed as part of recent work in the
github/codeql-action project.

I'm keeping the event type check for jobs already using it for the
time being.

refs atc0005/todo#60
atc0005 added a commit to atc0005/query-meta that referenced this issue Jun 9, 2023
This hook was previously needed for proper operation of the
`Vulnerability / CodeQL` job so that it could compare before/after
changes against the base branch.

This requirement was removed as part of recent work in the
github/codeql-action project.

I'm keeping the event type check for jobs already using it for the
time being.

refs atc0005/todo#60
atc0005 added a commit to atc0005/nagios-debug that referenced this issue Jun 9, 2023
This hook was previously needed for proper operation of the
`Vulnerability / CodeQL` job so that it could compare before/after
changes against the base branch.

This requirement was removed as part of recent work in the
github/codeql-action project.

I'm keeping the event type check for jobs already using it for the
time being.

refs atc0005/todo#60
atc0005 added a commit to atc0005/mysql2sqlite that referenced this issue Jun 9, 2023
This hook was previously needed for proper operation of the
`Vulnerability / CodeQL` job so that it could compare before/after
changes against the base branch.

This requirement was removed as part of recent work in the
github/codeql-action project.

I'm keeping the event type check for jobs already using it for the
time being.

refs atc0005/todo#60
atc0005 added a commit to atc0005/go-teams-notify that referenced this issue Jun 9, 2023
This hook was previously needed for proper operation of the
`Vulnerability / CodeQL` job so that it could compare before/after
changes against the base branch.

This requirement was removed as part of recent work in the
github/codeql-action project.

I'm keeping the event type check for jobs already using it for the
time being.

refs atc0005/todo#60
atc0005 added a commit to atc0005/go-nagios that referenced this issue Jun 9, 2023
This hook was previously needed for proper operation of the
`Vulnerability / CodeQL` job so that it could compare before/after
changes against the base branch.

This requirement was removed as part of recent work in the
github/codeql-action project.

I'm keeping the event type check for jobs already using it for the
time being.

refs atc0005/todo#60
atc0005 added a commit to atc0005/go-ezproxy that referenced this issue Jun 9, 2023
This hook was previously needed for proper operation of the
`Vulnerability / CodeQL` job so that it could compare before/after
changes against the base branch.

This requirement was removed as part of recent work in the
github/codeql-action project.

I'm keeping the event type check for jobs already using it for the
time being.

refs atc0005/todo#60
@atc0005
Copy link
Owner Author

atc0005 commented Jun 9, 2023

Tasks complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant