Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence spurious warning on autosummary config #158

Merged
merged 1 commit into from Feb 23, 2023
Merged

Silence spurious warning on autosummary config #158

merged 1 commit into from Feb 23, 2023

Conversation

simaoafonso-pwt
Copy link
Contributor

@simaoafonso-pwt simaoafonso-pwt commented Jan 31, 2023 •
edited by pllim

Fix #135

@simaoafonso-pwt
Copy link
Contributor Author

See #135

@pllim pllim requested a review from saimn January 31, 2023 17:23
@pllim pllim added this to the 0.15.0 milestone Jan 31, 2023
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #158 (5c322ad) into main (0479bd4) will decrease coverage by 0.07%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
- Coverage   89.90%   89.83%   -0.07%     
==========================================
  Files          27       27              
  Lines        1139     1141       +2     
==========================================
+ Hits         1024     1025       +1     
- Misses        115      116       +1
Impacted Files Coverage Δ
sphinx_automodapi/utils.py 90.59% <25.00%> (-0.71%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

saimn
saimn approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@saimn saimn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks !

@saimn saimn merged commit daa2a32 into astropy:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saimn saimn saimn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

Spurious warning on configuring nosignatures
3 participants
@simaoafonso-pwt @saimn @pllim