Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Report doctests raising skip exceptions as skipped #196

Merged
merged 3 commits into from
Apr 1, 2023

Conversation

effigies
Copy link
Contributor

@effigies effigies commented Mar 29, 2023

Closes #195.

@effigies effigies changed the title ENH: Report doctests raising skip exceptions as skippedatch skips or test outcomes ENH: Report doctests raising skip exceptions as skipped Mar 29, 2023
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks promising, thanks! I would like saimn to review too since he last updated the code.

@pllim pllim requested review from saimn and bsipocz March 30, 2023 00:17
@pllim pllim added this to the 0.12.2 milestone Mar 30, 2023
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me, thanks @effigies!

@pllim pllim merged commit 29cbdaa into scientific-python:main Apr 1, 2023
@pllim
Copy link
Contributor

pllim commented Apr 1, 2023

Thank you, all!

@bsipocz bsipocz modified the milestones: 0.12.2, 0.13 Jun 8, 2023
@effigies effigies deleted the enh/catch-skips branch March 4, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytest.skip() results in UnexpectedException error
3 participants