Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ePSF weights are passed as data.uncertainty #734

Open
Onoddil opened this issue Oct 4, 2018 · 0 comments · May be fixed by #739
Open

ePSF weights are passed as data.uncertainty #734

Onoddil opened this issue Oct 4, 2018 · 0 comments · May be fixed by #739
Labels

Comments

@Onoddil
Copy link
Contributor

Onoddil commented Oct 4, 2018

When creating EPSFStar instance in extract_stars weights can be pulled from data.uncertainty.array but are never converted to weights, with weights simply being the quoted uncertainty. This is then propagated into EPSFFitter._fit_star where weights can be passed to fitter, which would lead to the case that lower quality data would receive a higher relative weighting than high signal-to-noise data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants