-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test failures in predeps job (pre-release dependencies) #15807
Comments
I think most, if not all of these are caused by an intentional change in pytest 8.0.0rc1 . It's listed in https://docs.pytest.org/en/latest/changelog.html#other-breaking-changes, and I'll quote the relevant line for reference:
In other words, tests where
I don't have required expertise to guess what's preferable in all cases but I'm going to go with option 1, which is less work, and open a PR to start the discussions. |
Ah actually I'm able to reproduce this error by running the exact
so right now I'm out of ideas. For now I'll leave it at rest, hoping we (I ?) can think of a smart way to systematically look for the relevant difference, otherwise it might take a while. |
I am guessing you are talking about the remaining failure in #15809 in |
That's right ! Sorry I meant to comment on the PR but apparently got mixed up. |
About the
The easy fix would be to run the test when there is only one thread. |
Made by @chanley 17 years ago... I wonder if he remembers why. |
Example log: https://github.com/astropy/astropy/actions/runs/7392979516/job/20112234044
Things in RC:
Since we test against scipy-dev and pytest-dev (in different jobs though), likely culprit is pandas, but we might have also overlooked something that snuck in any of the dev during the holidays.
io/fits/tests/test_util.py:27
withFailed: DID NOT WARN.
table/tests/test_mixin.py:170
withAstropyUserWarning: Earth Location "TOPOCENTER" for Time Column "atcb" is incompatible with scale "TCB".
(2 similar failures)timeseries/io/tests/test_kepler.py:107
withUnitsWarning: 'BJD - 2457000, days' did not parse as fits unit
timeseries/tests/test_sampled.py:399
withUnitsWarning: 'BJD - 2457000, days' did not parse as fits unit
utils/tests/test_data.py:1101
withCacheMissingWarning: Remote data cache could not be accessed due to OSError
Some of these also look suspicious. I wonder if there was a remote network failure and these are transient.I restarted the job and all the failures remain. Whoever wants to investigate will have to install pre-release(s) of suspected package(s) and see if you can reproduce the errors.The text was updated successfully, but these errors were encountered: